Project

General

Profile

Actions

Bug #9002

closed

[rudder-packages] Make downloading files in Makefile be done in two steps

Added by Janos Mattyasovszky over 7 years ago. Updated over 7 years ago.

Status:
Released
Priority:
N/A
Assignee:
-
Category:
Packaging
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

When make is processing the files as targets, the WGET is downloading directly the file.
When the download fails, the zero-sized file is still present in the FS as WGET pre-allocates it.
This causes make skip that step as the "file is present", even if it is invalid.
Therefore make the WGET download the file to a temp file, and only move it to the required filename when the download succeeded.

Actions #1

Updated by Janos Mattyasovszky over 7 years ago

  • Category changed from System techniques to Packaging
Actions #2

Updated by Benoît PECCATTE over 7 years ago

  • Target version set to 4.0.0~rc2

Good idea

Actions #3

Updated by Janos Mattyasovszky over 7 years ago

  • Pull Request set to https://github.com/Normation/rudder-packages/pull/1045
Actions #4

Updated by Janos Mattyasovszky over 7 years ago

  • Status changed from New to Pending release
  • % Done changed from 0 to 100
Actions #5

Updated by Benoît PECCATTE over 7 years ago

  • Target version changed from 4.0.0~rc2 to 318
Actions #6

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 318 to 4.0.0~rc2
Actions #7

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.0.0~rc2 to 4.0.0~rc1
Actions #8

Updated by Alexis Mousset over 7 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.0.0 which was released the 10th November 2016.

Actions

Also available in: Atom PDF