Bug #9356: Change rudder_common_report to automatically convert the report type based on audit mode - Rudder - Issue Tracker

Actions

Copy link

Bug #9356

closed

User story #1808: Add an Audit mode to Rudder: only check properties, no modification on nodes

Bug #9265: Add support for audit_* reports in rudder stdlib

Change rudder_common_report to automatically convert the report type based on audit mode

Added by Nicolas CHARLES about 8 years ago. Updated about 8 years ago.

Status:

Released

Priority:

N/A

Assignee:

Nicolas CHARLES

Category:

System techniques

Target version:

4.0.0~rc1

Pull Request:

https://github.com/Normation/rudder-t...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

Techniques are full of calls to rudder_common_report, with hard_coded result_success, repaired or error
We should update the rudder_common_report to automatically map the result to the right value in audit

String	Enforce	Audit
result_na	result_na	audit_na
result_success	result_success	audit_compliant
result_repaired	result_repaired	audit_error
result_error	result_error	audit_noncompliant

A quick remark: the mapping result_error > audit_noncompliant is not complete, as the case n errors + 1 repaired leads to result_error in enforce but it leads to audit_error in audit (error wins in enforce, but repair wins in audit)

Subtasks 1 (0 open — 1 closed)

Actions

Copy link

Updated by Benoît PECCATTE about 8 years ago

Status changed from New to In progress

Actions

Copy link

Updated by Benoît PECCATTE about 8 years ago

Status changed from In progress to Pending technical review
Assignee changed from Benoît PECCATTE to Nicolas CHARLES
Pull Request set to https://github.com/Normation/rudder-techniques/pull/1057

PR https://github.com/Normation/rudder-techniques/pull/1057

Actions

Copy link