Project

General

Profile

Actions

Bug #10003

closed

Not having set %{real_name} does operate on /bin

Added by Janos Mattyasovszky about 7 years ago. Updated about 7 years ago.

Status:
Released
Priority:
N/A
Category:
Packaging
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

On branch: branches/rudder/4.1 (4.1.0.beta1):

./rudder-server-relay/SPECS/rudder-server-relay.spec:

147 # Clean up unwanted binaries
148 if [ "z%{real_name}" != "" ]; then
149   for i in easy_install python pip; do
150       rm -f %{real_name}/bin/${i}*
151   done
152 else
153   echo "WARNING: Skipping Virtualenv cleanup, as it" 
154   echo "WARNING: would operate on /bin ..." 
155   echo "WARNING: Please make sure the real_name macro" 
156   echo "WARNING: is defined" 
157 fi

=> You have added a "z" to the left side of the equation, but not to the right side, so it will always be unequal, so the implemented safety measures are useless...


Subtasks 1 (0 open1 closed)

Bug #10008: Not having set %{real_name} does operate on /binReleasedAlexis MoussetActions
Actions #1

Updated by Benoît PECCATTE about 7 years ago

  • Category set to Packaging
  • Target version set to 4.1.0~beta2
Actions #2

Updated by Benoît PECCATTE about 7 years ago

  • Status changed from New to In progress
  • Assignee set to Benoît PECCATTE
Actions #3

Updated by Benoît PECCATTE about 7 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Benoît PECCATTE to Alexis Mousset
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/1208
Actions #4

Updated by Benoît PECCATTE about 7 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #5

Updated by Vincent MEMBRÉ about 7 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.0 which was released today.

Actions

Also available in: Atom PDF