Project

General

Profile

Actions

Bug #10215

closed

"Delete" button is missnig for rule categories on some DPI resolution

Added by Dmitry Svyatogorov almost 8 years ago. Updated about 5 years ago.

Status:
Rejected
Priority:
N/A
Assignee:
-
Category:
Web - UI & UX
Target version:
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
Infrequent - complex configurations | third party integrations
Effort required:
Medium
Priority:
20
Name check:
Fix check:
Regression:

Description

In Rudder 4.0.2, "Categories" frame in "rudder/secure/configurationManager/ruleManagement" does not provides method to delete rules category, even in case it's empty.


Files

delete-icon-hover.png (9.19 KB) delete-icon-hover.png Raphael GAUTHIER, 2017-02-17 12:17
rudder_3.2.10.png (3.62 KB) rudder_3.2.10.png Dmitry Svyatogorov, 2017-02-17 12:26
rudder_4.0.2.png (3.23 KB) rudder_4.0.2.png Dmitry Svyatogorov, 2017-02-17 12:27
traffic_lights_4.0.2.png (11.3 KB) traffic_lights_4.0.2.png Dmitry Svyatogorov, 2017-02-17 12:34
rudder_4.0.3-my_font.png (12.1 KB) rudder_4.0.3-my_font.png Dmitry Svyatogorov, 2017-02-28 12:24
rudder_4.0.3-own_font.png (12.7 KB) rudder_4.0.3-own_font.png Dmitry Svyatogorov, 2017-02-28 12:24

Related issues 1 (0 open1 closed)

Related to Rudder - Bug #12073: "List nodes" page displays no looking glass icon on the right of the node name b/c of personnal fontRejectedActions
Actions #1

Updated by Vincent MEMBRÉ almost 8 years ago

  • Assignee set to Raphael GAUTHIER

Arg, Raphael can you look at this ?

Actions #2

Updated by Raphael GAUTHIER almost 8 years ago

  • Status changed from New to In progress
Actions #3

Updated by Raphael GAUTHIER almost 8 years ago

Normally, You can delete a rules category thanks to an icon which appears when you pass your mouse hover a category in the tree, as you can see on the attached file:

This icon is probably too small and not visible enough...

Updated by Dmitry Svyatogorov almost 8 years ago

Attached 3.2.10 vs 4.2.0 rule categories screenshot. Firefox 45.7.0 ESR.
  • And yes, the old stile was much more friendly for my eyes. Because of significantly less aggressive palette. Just look at "traffic_lights_4.0.2.png".
Actions #5

Updated by Vincent MEMBRÉ almost 8 years ago

Can you try empty the cache of your browser ? (Ctrl + F5 on firefox)

This does not look like that in any browser i tried, on any machine i have seen it run, but having a cache is the only explanation

Actions #6

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 4.0.3 to 4.0.4
Actions #7

Updated by Dmitry Svyatogorov almost 8 years ago

Yes, the problem localizes in Firefox ESR (all content blockers switched off), regardless of ctrl+F5. Distinct installation of 4.0.2 is affected too.
At least KDE Konqueror displays both icons.
I'll try to examine the page against latest firefoxes.
  • It seems that the new design is too complex for firefox. Although "Group parameters" for Rudder 4.0.2 are displayed in awful twice-scrolled frame, while for 3.2.10 looks ok.
Actions #8

Updated by Vincent MEMBRÉ almost 8 years ago

I did try with a Firefox ESR 45.7.0, and it works as fine as latest firefox :(

DO you have any errors in your javascript console ? or network errors in your firefox ?

Actions #9

Updated by Benoît PECCATTE almost 8 years ago

  • Found in version (s) 4.0.2 added
Actions #10

Updated by Benoît PECCATTE almost 8 years ago

  • Found in version(s) old deleted (4.0.2)
Actions #11

Updated by Dmitry Svyatogorov almost 8 years ago

Finally, I found the cause.
The Rudder icon set appears ok when rastering with the custom font from new rudder's theme (since 4.0, in 3.2 css was partitially reverted after my request, but in 4.0 it breaks my eyes again).
But it has no pixel-to-pixel bitmaps (at least for 96 dpi) and looks ugly with small-dpi displays.
I forbade non-system fonts and use arial from ms-tt inside my openSUSE. And it caused the right-side icon to not to be displayed at all.

  • I suppose than in 4.0 right icon is placed too close to the right side and so provokes rendering mistake. In this case, it must to exhibit as well together with large fonts.
Actions #12

Updated by François ARMAND almost 8 years ago

Ho, thank you for investigating that one. Raphael, would please try with these explanation?
Also, we need to be more careful about accessibility - at least test on 96dpi. For the font, we should at least ensure that everything is good-ish with standard system fonts.

Dimitri, could you tell us why you forbad non system fonts? So that everybody is aware of that constraint (you're certainly not the only one).

Updated by Dmitry Svyatogorov almost 8 years ago

Just look at "rudder_4.0.3-own_font.png" vs "rudder_4.0.3-my_font.png".
My current 24" displays have about 100 DPI resolution (≈1920/450*25), so individual point is well visible.
For correct smoothing it must have at least 3x more points (300+ DPI like first generation of "laser" printers). Otherwise (at least my) eyes gets "misfocused".
Thereby I use non-smoothed small fonts that contains a set of low-size bitmaps. At this point of time it is well-known ms-tt ("arial" & "courier new"), which embeds bitmaps for 96 DPI canvas.
  • It's noticeable huge job to produce well-looking font set for other DPI and thus very few alternatives available.
Actions #14

Updated by François ARMAND almost 8 years ago

Thanks, I know fonts are hard (local or time/timezone level hard). Raphael, can you look to that?

Actions #15

Updated by François ARMAND almost 8 years ago

  • Severity set to Major - prevents use of part of Rudder | no simple workaround
  • User visibility set to Infrequent - complex configurations | third party integrations
Actions #16

Updated by Benoît PECCATTE over 7 years ago

  • Priority set to 25
Actions #17

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.0.4 to 4.0.5
Actions #18

Updated by Jonathan CLARKE over 7 years ago

  • Status changed from In progress to New
Actions #19

Updated by Jonathan CLARKE over 7 years ago

  • Assignee deleted (Raphael GAUTHIER)
Actions #20

Updated by Raphael GAUTHIER over 7 years ago

  • Effort required set to Medium
  • Priority changed from 25 to 24
Actions #21

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.0.5 to 4.0.6
  • Priority changed from 24 to 23
Actions #22

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.0.6 to 4.0.7
Actions #23

Updated by Raphael GAUTHIER over 7 years ago

As you said, there are only few alternatives available. Concerning the delete icon, as you forbade non-system fonts, font-awesome (which is a font too) is also blocked so icons can't appear. The only workaround I see is use images instead of font. It's doable, but it's a lot of work, since all icons' font properties have to be replaced by other properties (eg font-size --> height), and this will be less flexible (eg the icons color could no longer be changed in css).

Concerning the font, if it does not adapt to any DPI, we should change it.

Actions #24

Updated by Dmitry Svyatogorov over 7 years ago

1. "Edit" button passes from the same font? It appears ok, so firefox is not so stupid to forbid symbol fonts. As far as I view, there is not enough canvas, 1…2 pixels are missing. The easy workaround is to place 2…3 blanks on the right, instead of huge redesign.
2. Delete button may be duplicated inside "Update" form.
3. Groups categories has "Delete" button on right-bottom of "Category details" area. It's enough to do the things. While not to make interfaces more uniform by implementing "Update" and "Delete" in some predictable place of every form?

Actions #25

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.0.7 to 357
Actions #26

Updated by Alexis Mousset over 7 years ago

  • Target version changed from 357 to 4.1.6
Actions #27

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.1.6 to 4.1.7
  • Priority changed from 23 to 22
Actions #28

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.1.7 to 4.1.8
Actions #29

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 4.1.8 to 4.1.9
  • Priority changed from 22 to 21
Actions #30

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 4.1.9 to 4.1.10
Actions #31

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 4.1.10 to 4.1.11
  • Priority changed from 21 to 20
Actions #32

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.1.11 to 4.1.12
Actions #33

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.1.12 to 4.1.13
Actions #34

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.1.13 to 4.1.14
Actions #35

Updated by Benoît PECCATTE over 6 years ago

  • Target version changed from 4.1.14 to 4.1.15
Actions #36

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.1.15 to 4.1.16
Actions #37

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.1.16 to 4.1.17
Actions #38

Updated by François ARMAND about 6 years ago

  • Subject changed from "Delete" button is absent for rule categories to "Delete" button is missnig for rule categories on some DPI resolution
Actions #39

Updated by François ARMAND about 6 years ago

  • Related to Bug #12073: "List nodes" page displays no looking glass icon on the right of the node name b/c of personnal font added
Actions #40

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.1.17 to 4.1.18
Actions #41

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.1.18 to 4.1.19
Actions #42

Updated by Alexis Mousset almost 6 years ago

  • Target version changed from 4.1.19 to 4.1.20
Actions #43

Updated by François ARMAND almost 6 years ago

  • Target version changed from 4.1.20 to 4.1.21
Actions #44

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.21 to 4.1.22
Actions #45

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.22 to 4.1.23
Actions #46

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.23 to 4.1.24
Actions #47

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.24 to 588
Actions #48

Updated by Félix DALLIDET over 5 years ago

  • Status changed from New to Rejected

Closing since this is inactive for a very long time, and I could not reproduce on the 5.0.

Actions #49

Updated by Alexis Mousset about 5 years ago

  • Target version changed from 588 to 4.1.24
Actions

Also available in: Atom PDF