Project

General

Profile

Architecture #11913

no reporting if value to report contains a variable

Added by Vincent MEMBRÉ over 1 year ago. Updated about 1 year ago.

Status:
Released
Priority:
N/A
Category:
Technique editor - API
Target version:
Effort required:

Description

Let's say you want your technique to edit a file /tmp/${bar} with a file_ensure_lines_present method where bar is either a variable definedby another method or a parameter of the technique (value defined in a Directive in 4.3). You will never get a report for this method since the variable won't have any value while expanding reporting file (expected_reports.csv)

We should comppletely change the way reporting is made on ncf techniques; by replacing the csv file system by creating a context where the reporting method will get the value of the current technique/directive/method.

Values extracted from CSV are:

  • The technique name
  • Component to report
  • Value of the component to report
  • The reporting identifier (aka the tracking key) composed of:
    • THe Rule ID
    • The Directive ID

Thus will largeky simplify logger_rudder method and remove a lot of magic.

Context needs to be set befor elogger method is called.

The techniqe needs to change the reproting context before each method call ( component to report, and it's value, and the technique name) *
Rudder needs to set Directive/Rule context before calling the technique bundle.


Subtasks

Rudder - Architecture #11914: Add Rudder reporting context before calling technique bundleReleasedVincent MEMBRÉActions
Rudder - Architecture #11929: Remove calls related to expected resports csv files from rudder techniquesReleasedBenoît PECCATTEActions
Architecture #11930: Add a way to prevent reporting of methodsReleasedBenoît PECCATTEActions
Architecture #12172: Prevent reporting of inner methods in Rudder ReleasedBenoît PECCATTEActions
Architecture #12180: typo in new loggerReleasedBenoît PECCATTEActions
Architecture #12181: typo in new loggerReleasedBenoît PECCATTEActions
Architecture #12185: Broken policies after changes in the loggerRejectedActions
Architecture #11939: Adapt associated testsReleasedNicolas CHARLESActions
Bug #12035: ncf does not report on the correct component name in Rudder 4.3ReleasedNicolas CHARLESActions
Architecture #12044: Add a script to rewrite a technique from command lineReleasedVincent MEMBRÉActions
Bug #12078: ncf techniques are not reporting on the correct technique nameReleasedBenoît PECCATTEActions
Rudder - Bug #12079: Add information about technique name/id to directive contextReleasedBenoît PECCATTEActions
Rudder - Bug #12085: Add information about technique name/id to directive contextReleasedBenoît PECCATTEActions
Bug #12084: Broken tests after parent changeReleasedVincent MEMBRÉActions

Related issues

Related to ncf - Bug #12087: command_execution_result does not report anythingReleasedActions
Related to ncf - Architecture #11915: Remove expected reports.csv logicReleasedActions

Associated revisions

Revision f61dd738 (diff)
Added by Vincent MEMBRÉ over 1 year ago

Fixes #11913: no reporting if value to report contains a variable

History

#1

Updated by Vincent MEMBRÉ over 1 year ago

  • Status changed from New to In progress
#2

Updated by Vincent MEMBRÉ over 1 year ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/ncf/pull/674
#3

Updated by Vincent MEMBRÉ over 1 year ago

  • Status changed from Pending technical review to Pending release
#4

Updated by Nicolas CHARLES over 1 year ago

  • Related to Bug #12087: command_execution_result does not report anything added
#5

Updated by Vincent MEMBRÉ over 1 year ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.3.0~beta1 which was released today.

#6

Updated by Vincent MEMBRÉ about 1 year ago

Also available in: Atom PDF