Project

General

Profile

Actions

Bug #12257

closed

Use pom-template.xml + makefile to avoid variables in artifact version in pom.xml

Added by François ARMAND over 6 years ago. Updated over 6 years ago.

Status:
Released
Priority:
N/A
Category:
Packaging
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

So. It seems that anything in the way to parametrize versions in maven pom breaks thing in way or another, sometime most exotic one (like the install part that works for plugins-common but not for plugin-common-private, whereas they are the same pom bare the dependency on the second towards the first).

Even trying to pass values in -D parameters does not work in homogenous way. Some plugins get the correct version, others don't. No heuristic was conclusive appart that maven is a mad god who severly punish whoever try to go out of THE MAVEN WAY.

One thing that might have worked is to use environment variables for version, because these one are resolved before anything else. But that would have mean breaking IDE integration.

So. We will use pom template, and generate pom with the correct, verbatim version number in them. Let the god be happy with his only possible way.

Actions #1

Updated by François ARMAND over 6 years ago

  • Subject changed from maven furious. maven requires more life sacrifice to be happy, to maven furious. maven requires more life sacrifice to be happy
Actions #2

Updated by François ARMAND over 6 years ago

  • Subject changed from maven furious. maven requires more life sacrifice to be happy to maven furious. maven requires more life sacrifices to be happy
Actions #3

Updated by François ARMAND over 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-plugins/pull/26
Actions #4

Updated by François ARMAND over 6 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:rudder-plugins|e6495ffe0571b59b86230e870b7918b83e15d45a.

Actions #5

Updated by François ARMAND over 6 years ago

  • Subject changed from maven furious. maven requires more life sacrifices to be happy to Use pom-template.xml + makefile to avoid variables in artifact version in pom.xml
Actions #6

Updated by Alexis Mousset over 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.11, 4.2.5 and 4.3.0~rc3 which were released today.

Actions #7

Updated by Vincent MEMBRÉ over 6 years ago

  • Project changed from Rudder to Rudder plugins
  • Category changed from Plugins integration to Packaging
  • Target version changed from 4.1.11 to 4.1
Actions

Also available in: Atom PDF