Project

General

Profile

Bug #12512

Buttons don't follow a straight design

Added by Janos Mattyasovszky 8 months ago. Updated 6 months ago.

Status:
Pending release
Priority:
N/A
Category:
Web - UI & UX
Target version:
Severity:
Trivial - no functional impact | cosmetic
User visibility:
First impressions of Rudder
Effort required:
Priority:
76

Description

At 4.3.0.rc3:

The Node management -> Search nodes has it's "Create node group from this query" on the left side and is gray.

When you go do the Node Management -> Groups, the [Create] Button is "hidden" next to the Filter's [X] button, and is gray.

At the Configuration policy -> Rules, the Add category is green and has a white (+) within it, just like the "Create Rule" on the top right side.

At Directives if you select a directive in the tree, the Create Directive / .. with latest version buttons are green but don't have a (+) within and are also not in the top right side.

At Parameters the "Add Parameter" has a (+) and is on the side in the middle.

In the Technique Editor, the white (+) is on the left side of the button, the previous were on the right. also here the "Add Parameter" has a + not within a white circle with green but simply a while + without a circle.

At Settings -> Techniques the "Add category" is like at Groups, a gray button next to the filter's [x] button.

At API Accounts, the "Add API Account" is also on the left middle, now green, with a (+) in it.

It makes the eye find the right button a little bit difficult one if you click a lot while working on the GUI

Create-Add.png (6.92 KB) Create-Add.png Raphael GAUTHIER, 2018-04-23 11:33
1347

Related issues

Related to Rudder - Bug #12662: Some more buttons to make consistentPending release

Associated revisions

Revision aab0c5f9 (diff)
Added by Raphaël Gauthier 8 months ago

Fixes #12512: Buttons don't follow a straight design

History

#1 Updated by Janos Mattyasovszky 8 months ago

  • Subject changed from Button dont follow a straigt design to Buttons don't follow a straight design

#2 Updated by Janos Mattyasovszky 8 months ago

  • Description updated (diff)

#3 Updated by Raphael GAUTHIER 8 months ago

Hello Janos, thanks for your feedback.

You did well to open a bug for this, it's definitely something we need to fix in Rudder.

On the aesthetic level, we should differentiate 2 types of actions:
  • Create, which represents a "heavy" task (e.g., create a new Rule). This button should be extremely visible, since it represents a main feature of the page. Therefore, there should only be one per page.
  • Add, which represents a fast task of only a few seconds (e.g., Add Category in the Rules list). This kind of button should be more discreet, so as not to divert the user's attention. There could possibly be several per page.

The Create buttons should have a green background to be clearly visible, while the Add buttons should just have green borders and a white background, to be more discreet.

#4 Updated by Raphael GAUTHIER 8 months ago

1347

Example :

#5 Updated by Janos Mattyasovszky 8 months ago

My biggest confusion were the gray buttons "hidden" next to the filter part, I had to look approx for 10 seconds to find it, which caused a little frustration since I got kicked out of my think-process, but aligning the UI Items according to the criticality of the resulting action is also something nice.

#6 Updated by Raphael GAUTHIER 8 months ago

  • Target version set to 4.1.12

#7 Updated by Raphael GAUTHIER 8 months ago

  • Status changed from New to In progress
  • Assignee set to Raphael GAUTHIER

#8 Updated by Raphael GAUTHIER 8 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Raphael GAUTHIER to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/1911

#9 Updated by Normation Quality Assistant 8 months ago

  • Assignee changed from Vincent MEMBRÉ to Raphael GAUTHIER

#10 Updated by Anonymous 8 months ago

  • Status changed from Pending technical review to Pending release

#11 Updated by Benoît PECCATTE 6 months ago

  • Priority changed from 77 to 76

This bug has been fixed in Rudder 4.1.12, 4.2.6 and 4.3.1 which were released today.

#12 Updated by Vincent MEMBRÉ 5 months ago

  • Related to Bug #12662: Some more buttons to make consistent added

Also available in: Atom PDF