Project

General

Profile

Architecture #12558

Enforce stricter checks by scala compiler with Xlint flags

Added by François ARMAND 7 months ago. Updated 6 months ago.

Status:
Released
Priority:
N/A
Category:
Architecture - Internal libs
Target version:
Effort required:

Description

We don't use scala compiler to its full power. In fact, we don't even use it for simple things like unused imports.

In #11955, we did an ad hoc compilation with the interesting flags, but it is not persistent and we need to enforce them in Maven pom to be sure to not drift from the clean state.

https://tpolecat.github.io/2017/04/25/scalac-flags.html gives an overview of all the interesting flags. We won't use them all right now, because our code base it not ready :)

We will also need to be able to selectively silent some warning, in particular in the case of deprecationWarning for things that can't be replaced (easely or at all, like Thread.stop). For that, we will use the silencer plugin: https://github.com/ghik/silencer

This change will span modification on all scala projects, this ticket handle modifications in `parent-pom` one.


Subtasks

Architecture #12559: Correct scalac warnings in rudder-commonsReleasedVincent MEMBRÉ
Architecture #12560: Correct scalac warnings in scala-ldapReleasedVincent MEMBRÉ
Architecture #12561: Correct scalac warnings in ldap-inventoryReleasedVincent MEMBRÉ
Architecture #12562: Correct scalac warnings in rudderReleasedVincent MEMBRÉ
Bug #12644: Stacktrace when displaying comet componentsReleasedFrançois ARMAND

Related issues

Has duplicate Rudder - Architecture #2619: Add a style checking tool for ScalaRejected

Associated revisions

Revision 43fd97fb (diff)
Added by François ARMAND 7 months ago

Fixes #12558: Enforce stricter checks by scala compiler with Xlint flags

History

#1 Updated by François ARMAND 7 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder-parent-pom/pull/53

#2 Updated by François ARMAND 7 months ago

We also update some libraries that help with false positives with these compiler flags.

#3 Updated by François ARMAND 7 months ago

  • Status changed from Pending technical review to Pending release

#4 Updated by Nicolas CHARLES 6 months ago

#5 Updated by Vincent MEMBRÉ 6 months ago

  • Category changed from Web - Maintenance to Architecture - Internal libs

#6 Updated by Vincent MEMBRÉ 6 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.3.2 which was released today.

Also available in: Atom PDF