Project

General

Profile

Actions

Bug #12749

closed

rudder-pkg should fail installation is a dependency is missing

Added by François ARMAND over 6 years ago. Updated over 6 years ago.

Status:
Released
Priority:
N/A
Category:
Plugins integration
Target version:
Severity:
Minor - inconvenience | misleading | easy workaround
UX impact:
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Very Small
Priority:
61
Name check:
Fix check:
Regression:

Description

Today, rudder-pkg install a package even if some of its dependencies are missing, and it prints a warning message.

This is in general not what we want, because nobody seems to read warning and people keep get stuck not knowing why the plugin does not work (for ex after #11115 correction).

Actions #1

Updated by Benoît PECCATTE over 6 years ago

This has been done because we have no generic way to install a package from shell.
We could implement this using ncf script, ncf knows how to do this.

Actions #2

Updated by Vincent MEMBRÉ over 6 years ago

We already check if the dependency if fullfilled or not, but we only display a warning message and install rpkg and run postint with success which leads to a broken plugin

The idea is to check dependencies before doing anything, and if not present, do not install the rpkg so the user has no problem

The user still has to install dependencies himself

Actions #4

Updated by Benoît PECCATTE over 6 years ago

  • Status changed from New to In progress
Actions #5

Updated by Benoît PECCATTE over 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Benoît PECCATTE to Alexis Mousset
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/1605
Actions #6

Updated by Benoît PECCATTE over 6 years ago

  • Status changed from Pending technical review to Pending release
Actions #7

Updated by Vincent MEMBRÉ over 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.13, 4.2.7 and 4.3.3 which were released today.

Actions

Also available in: Atom PDF