Bug #13786: Missing report for component "Post-modification hook" when cleaning files with "File and directory basics" Technique version 4.1 - Rudder - Issue Tracker

Actions

Copy link

Bug #13786

closed

Missing report for component "Post-modification hook" when cleaning files with "File and directory basics" Technique version 4.1

Added by Renaud Manus over 5 years ago. Updated almost 2 years ago.

Status:

Released

Priority:

N/A

Assignee:

Benoît PECCATTE

Category:

Techniques

Target version:

4.3.7

Pull Request:

https://github.com/Normation/rudder-t...

Severity:

Minor - inconvenience | misleading | easy workaround

UX impact:

User visibility:

Operational - other Techniques | Rudder settings | Plugins

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

This is a follow up from Bug#12297

When cleaning files, the post modification hook is still not executed and it is reported missing.

See screenshot in attachment for the directive and the following logs when executed

rudder     info: Deleted file '/etc/fail2ban/jail.d/defaults-debian.conf'
E| n/a           manageFilesAndFolders     Permissions               /etc/fail2ban/jai| The item /etc/fail2ban/jail.d/defaults-debian.conf was not requested to have its permission enforced
E| compliant     manageFilesAndFolders     File                      /etc/fail2ban/jai| File cleaning was requested for /etc/fail2ban/jail.d/defaults-debian.conf. Check specific reporting in the 'File cleaning options' component.
E| repaired      manageFilesAndFolders     File cleaning options     /etc/fail2ban/jai| The item /etc/fail2ban/jail.d/defaults-debian.conf has been put in conformity with the deletion policy

There is no mention of the Post-modification hook being executed and I confirmed that indeed it was not executed.

I'm running rudder server 4.3.2 and rudder agent 4.3.6

Files

Capture d’écran 2018-11-08 à 10.42.53.png (84.5 KB) Capture d’écran 2018-11-08 à 10.42.53.png

Renaud Manus, 2018-11-08 10:44

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Renaud Manus over 5 years ago

Related to Bug #12297: Missing report for component "Post-modification hook" when cleaning files added

Actions

Copy link

Updated by Vincent MEMBRÉ over 5 years ago

Thanks Renaud for reporting !

Which version of the technique are you using ? I think the bug is fixed in 4.0 version of this technique (Done in #12297) but 4.1 version (introduced in Rudder 4.3 does not have the fix)

If you are using the 4.0 version, you need to update it (bugfixes in techniques are not propagated automatically, see https://docs.rudder.io/reference/5.0/installation/upgrade/rhel.html#_technique_upgrade) but we'll look deeper if you need!

Actions

Copy link

Updated by Renaud Manus over 5 years ago

I'm using Technique v4.1.

I'm not sure to understand your last note. You wrote that the bug is fixed in 4.0 but not in 4.1 then you recommend to upgrade from 4.0 to 4.1, is that correct ?

Thanks

Actions

Copy link

Updated by Vincent MEMBRÉ over 5 years ago

Translation missing: en.field_tag_list set to Sponsored
Subject changed from Missing report for component "Post-modification hook" when cleaning files to Missing report for component "Post-modification hook" when cleaning files with "File and directory basics" Technique version 4.1
Target version set to 4.3.7

In fact, we fix bugs in technique without changing their version number, so when i say "upgrading techniques" it's not changing the version of the technique used but upgrading the files of the technique with the latest content which is not automatically done (see this link https://docs.rudder.io/reference/5.0/installation/upgrade/rhel.html#_technique_upgrade).

So we used to have a version 4.0 of the Technique with the bug in it.
We fixed it in Rudder 4.1.11 with issue #12297 in version 4.0 of the Technique. (and to have the fix in 4.0 you need to the upgrade procedure)
We created in Rudder 4.3.0 a new version 4.1 of the Technique but it was based on the old version of the technique.
When fix #12297 was upmergerd in 4.3 we did not modify 4.1 version of the technique to include the fix.

This means that: your 4.0 Technique may be ok (if you did upgrade the Technique) and the 4.1 Technique does not work.

We need to fix the 4.1 Technique.

As a workaround, you can use the 4.0 version (after upgrrade of the technique) by downgrading all your 4.1 based Directives to 4.0

Actions

Copy link

Updated by Nicolas CHARLES over 5 years ago

Status changed from New to In progress
Assignee set to Nicolas CHARLES

Actions

Copy link

Updated by Nicolas CHARLES over 5 years ago

Status changed from In progress to Pending technical review
Assignee changed from Nicolas CHARLES to Benoît PECCATTE
Pull Request set to https://github.com/Normation/rudder-techniques/pull/1352

PR https://github.com/Normation/rudder-techniques/pull/1352

Actions

Copy link