Rudder

We may have forgot an escape somewhere.

1/ we need to find back what are the exact rules for authorized chars in what kind of names

=> either find original commit or relevant documentation/test
(MS: doc: https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_variables?view=powershell-7)

2/ adapt the rules to keep working cases working, and handle the news ones.

Step 1: Felix, can you document what cases of "_" are foriden

The issue here is not powershell based. It comes from the policy generation process:

• Given a "server_stuff" parameter, I end up with the following technique:
  

  function Badaboum {
    [CmdletBinding()]
    param (
        [parameter(Mandatory=$true)]
        [string]$reportId,
        [parameter(Mandatory=$true)]
        [string]$techniqueName,
        [parameter(Mandatory=$true)]
        [string]$ServerStuff,
        [Rudder.PolicyMode]$policyMode
    )
    BeginTechniqueCall -Name $techniqueName
    $reportIdBase = $reportId.Substring(0,$reportId.Length-1)
    $localContext = [Rudder.Context]::new($techniqueName)
    $localContext.Merge($system_classes)
    $resources_dir = $PSScriptRoot + "\resources" 
  
    $reportId=$reportIdBase+"58c380a3-3e54-4b39-bcf5-783340fa1793" 
    $componentKey = "Write-Host `"${server_stuff}`"" 
    $reportParams = @{
      ClassPrefix = ([Rudder.Condition]::canonify(("command_execution_" + $componentKey)))
      ComponentKey = $componentKey
      ComponentName = "Command execution" 
      PolicyMode = $policyMode
      ReportId = $reportId
      DisableReporting = $false
      TechniqueName = $techniqueName
    }
    $call = Command-Execution -Command "Write-Host `"${server_stuff}`"" -PolicyMode $policyMode
    $methodContext = Compute-Method-Call @reportParams -MethodCall $call
    $localContext.merge($methodContext)
    EndTechniqueCall -Name $techniqueName
  }
  

Which is false as the parameter of the technique is chnaged to "ServerStuff" instead of "server_stuff". It also needs to be changed in the directive.ps1 generated file.

PR https://github.com/Normation/rudder/pull/4563

Applied in changeset rudder|c2c7ec2f056edf734c902b7ac0d073232198ae0a.

This bug has been fixed in Rudder 7.1.8 and 7.2.2 which were released today.

• 7.1.8 changelog
• 7.2.2 changelog
• Upgrade manual