Project

General

Profile

Actions
Copy link

Bug #16278

closed

zypper_pattern module does not work in python3

Added by Félix DALLIDET almost 5 years ago. Updated over 2 years ago.

Status:
Released
Priority:
N/A
Assignee:
Benoît PECCATTE
Category:
Generic methods
Target version:
6.0.2
Pull Request:
https://github.com/Normation/ncf/pull...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Reviewed
Fix check:
Checked
Regression:

Description

Still true, we are opening the output from some commands as "text" and not "bytes" since we are using the universal_newlines type in a function.

Related issues 1 (0 open — 1 closed)

Related to Rudder - Bug #15522: zypper_pattern module does not work in python3ReleasedAlexis MoussetActions
Actions
Copy link
 #1

Updated by Félix DALLIDET almost 5 years ago

  • Related to Bug #15522: zypper_pattern module does not work in python3 added
Actions
Copy link
 #2

Updated by Félix DALLIDET almost 5 years ago

  • Status changed from New to In progress
  • Assignee set to Félix DALLIDET
Actions
Copy link
 #3

Updated by Félix DALLIDET almost 5 years ago

This only affect the zypper_pattern module, mostly because it is the only module which call cmd based on other cmd outputs.
Since python3, bytes and str are separated and we must pass on every string manipulation previously done and update them to be sure they never mix bytes and str.

Bytes are mostly coming from cmd outputs, but in some cases, the cmd output outputs str, I think the "universal_newline" option it the faulty member here.

Actions
Copy link
 #4

Updated by Alexis Mousset almost 5 years ago

  • Target version changed from 6.0.0 to 6.0.1
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 6.0.1 to 6.0.2
Actions
Copy link
 #6

Updated by Félix DALLIDET almost 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Félix DALLIDET to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/ncf/pull/1132
Actions
Copy link
 #7

Updated by Félix DALLIDET almost 5 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:40c69131ef48cc38570e5675b2a8bca1c40f21c7.

Actions
Copy link
 #8

Updated by Félix DALLIDET almost 5 years ago

  • Fix check changed from To do to Checked
Actions
Copy link
 #9

Updated by Alexis Mousset almost 5 years ago

  • Subject changed from zypper_pattern module does not work in python3 Bis to zypper_pattern module does not work in python3
  • Name check changed from To do to Reviewed
Actions
Copy link
 #10

Updated by Vincent MEMBRÉ almost 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 6.0.2 which was released today.

Actions
Copy link
 #11

Updated by Alexis Mousset over 2 years ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods - Package Management to Generic methods
Actions
Copy link

Also available in: Atom PDF