Project

General

Profile

Actions
Copy link

Bug #17481

closed

when running cf-promises, list-compatible-inputs is ran 8 times

Added by Nicolas CHARLES over 4 years ago. Updated over 4 years ago.

Status:
Released
Priority:
N/A
Assignee:
Alexis Mousset
Category:
Performance and scalability
Target version:
5.0.18
Pull Request:
https://github.com/Normation/rudder-t...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
Checked
Regression:

Description

Even thought the logs states that it is cached it is not

0.000170 rudder  verbose: Caching result for function 'execresult("${compatible_inputs_cmd} local","${shell_type}")'
0.061626 rudder  verbose: execresult ran 'NCF_CACHE_PATH=/var/rudder/cfengine-community/state /bin/sh /var/rudder/ncf/common/10_ncf_internals/list-compatible-inputs --capability-file /opt/rudder/etc/agent-capabilities --agent-version 3.15.1 --ncf-path '/var/rudder/ncf' common' successfully
0.000132 rudder  verbose: Caching result for function 'execresult("${compatible_inputs_cmd} common","${shell_type}")'
0.046734 rudder  verbose: execresult ran 'NCF_CACHE_PATH=/var/rudder/cfengine-community/state /bin/sh /var/rudder/ncf/common/10_ncf_internals/list-compatible-inputs --capability-file /opt/rudder/etc/agent-capabilities --agent-version 3.15.1 --ncf-path '/var/rudder/ncf' local' successfully

tested in 6.1 by adding a >> at the begining of the command

Actions
Copy link
 #1

Updated by Nicolas CHARLES over 4 years ago

  • Target version changed from 6.1.0~rc1 to 5.0.18

change is so minimal that it can go in 5.0

Actions
Copy link
 #2

Updated by Nicolas CHARLES over 4 years ago

with this, a cf-promises during policy generetation goes from 1.3s to 0.8s (roughly)

Actions
Copy link
 #3

Updated by Nicolas CHARLES over 4 years ago

  • Status changed from New to In progress
  • Assignee set to Nicolas CHARLES
Actions
Copy link
 #4

Updated by Nicolas CHARLES over 4 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Alexis Mousset
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/1600
Actions
Copy link
 #5

Updated by Nicolas CHARLES over 4 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #6

Updated by François ARMAND over 4 years ago

  • Fix check changed from To do to Checked
Actions
Copy link
 #7

Updated by Vincent MEMBRÉ over 4 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.18 and 6.1.2 which were released today.

Actions
Copy link

Also available in: Atom PDF