Project

General

Profile

Actions

Bug #17878

closed

All plugins are disabled after a minor upgrade

Added by Félix DALLIDET over 3 years ago. Updated over 3 years ago.

Status:
Released
Priority:
N/A
Category:
Plugins integration
Target version:
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
First impressions of Rudder
Effort required:
Priority:
94
Name check:
To do
Fix check:
Checked
Regression:

Description

When doing a minor upgrade of the server, all plugins are disabled before the upgrade and not re-enabled afterward.
This is very misleading for the users.
It displays the following error message:

********************************************************************************
Due to incompatibility reasons for this specific version all plugins have been
disabled. Make sure to update your repo index and install the latest version of
your plugins before re-enabling them.

You can use the following commands to upgrade your plugins:
rudder package update
rudder package upgrade-all
********************************************************************************

But running the given commands will not solve anything when applying a minor update.
It will only work on major ones.

It happens when upgrading from 6.0.6 to 6.0.8-nightly

But the plugins should not be changed in a minor update. I think this is an unclean workaround when we broke plugin compatibility in 6.0.4.
We should most likely either:
  • State than an upgrade disabled all plugins and let the user re-enabled them manually
  • Save the plugin state before update and try to re-enable them. This need to differentiate the minor upgrades from the major ones.

Subtasks 2 (0 open2 closed)

Bug #17947: Document how to enable/upgrade plugins after rudder upgradeReleasedAlexis MoussetActions
Bug #18311: Changes to rudder package command to improve plugin managementReleasedAlexis MoussetActions

Related issues 1 (0 open1 closed)

Related to Rudder - Bug #16792: When upgrading to 6.0.3 the packaging should disable all installed pluginsReleasedNicolas CHARLESActions
Actions #1

Updated by Nicolas CHARLES over 3 years ago

  • Related to Bug #16792: When upgrading to 6.0.3 the packaging should disable all installed plugins added
Actions #3

Updated by François ARMAND over 3 years ago

  • Severity changed from Minor - inconvenience | misleading | easy workaround to Major - prevents use of part of Rudder | no simple workaround
  • Priority changed from 80 to 100

The workaround is not easy.

We need to:

- correct message and add "rudder package enable or enable-all" to re-enable plugins and then "rudder upgrade-all"
- for 6.1: keep plugins enable
- for minor updates: we would like to automatically update plugins to good version

So, the general logic is:

- keep which plugins were enable before upgrade,
- re-enable plugins after upgrade && upgrade all

Actions #4

Updated by François ARMAND over 3 years ago

  • Assignee set to Félix DALLIDET
Actions #5

Updated by Vincent MEMBRÉ over 3 years ago

  • Target version set to 6.1.6
  • Priority changed from 100 to 96
Actions #6

Updated by Vincent MEMBRÉ over 3 years ago

  • Status changed from New to In progress
  • Assignee changed from Félix DALLIDET to Vincent MEMBRÉ
Actions #7

Updated by Vincent MEMBRÉ over 3 years ago

  • Assignee changed from Vincent MEMBRÉ to Alexis Mousset
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/2368
Actions #8

Updated by Vincent MEMBRÉ over 3 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis Mousset to Félix DALLIDET
Actions #9

Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 6.1.6 to 6.2.0~beta1
Actions #10

Updated by Vincent MEMBRÉ over 3 years ago

  • Assignee changed from Félix DALLIDET to Alexis Mousset
  • Priority changed from 96 to 95
Actions #11

Updated by Vincent MEMBRÉ over 3 years ago

  • Assignee changed from Alexis Mousset to Félix DALLIDET
Actions #12

Updated by Vincent MEMBRÉ over 3 years ago

  • Assignee changed from Félix DALLIDET to Alexis Mousset
Actions #13

Updated by Vincent MEMBRÉ over 3 years ago

  • Status changed from Pending technical review to Pending release
Actions #14

Updated by Vincent MEMBRÉ over 3 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 6.2.0~beta1 which was released today.

Actions #15

Updated by Elaad FURREEDAN over 3 years ago

  • Priority changed from 95 to 94
  • Fix check changed from To do to Checked
Actions

Also available in: Atom PDF