Bug #18100: Techniques with conditions on tasks with very long parameters report "missing" parts on the dashboard - Rudder - Issue Tracker

Custom queries

8.1 beta
Bugs triage
My TR
Need technical review
Open bugs (all)
Open bugs (UI - UX)
Open UX defects (all)
Opened by users

Actions

Copy link

Bug #18100

closed

Techniques with conditions on tasks with very long parameters report "missing" parts on the dashboard

Added by PB LO over 3 years ago. Updated over 3 years ago.

Status:

Released

Priority:

N/A

Assignee:

Alexis Mousset

Category:

Web - Config management

Target version:

6.0.8

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

To do

Fix check:

Error - Next version

Regression:

Description

Hi,

I've try the 6.1.3 version and get an issue with techniques.
If I put a condition on a task (to be compatible between RHEL and Debian by example), "rudder agent run" works without error, but the ignored tasks are reported as "missing" on the dashboard.
Screenshots as attachment.

Regards.

Subtasks 1 (0 open — 1 closed)

Bug #18102: create a specific bundle specific for NA reports

Released

Alexis Mousset

Actions

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by PB LO over 3 years ago

Actions

Copy link

Updated by Nicolas CHARLES over 3 years ago

Target version set to 6.1.4

might be related to https://issues.rudder.io/issues/18027

Actions

Copy link

Updated by PB LO over 3 years ago

In the related issue #18027 said that it's resolved in 6.1.2. It's not ?

Actions

Copy link

Updated by Nicolas CHARLES over 3 years ago

it might be introduced by #18027
I did not reproduce exactly this issue, but it seems that changing the name of generic method for reporting causes issues in reporting (i have spurious repaired on a skipped method)

Actions

Copy link

Updated by Nicolas CHARLES over 3 years ago

I have trouble reproducing exactly this error - I have error where repairs leaks to result_na though
would it be possible for you to sent us the verbose output of the agent obtained by rudder agent run -v?

you can sent it to me personally if you'd rather not have it on the internet has it may contain sensitive data

Actions

Copy link

Updated by Nicolas CHARLES over 3 years ago

Log file revealed that issue is caused by the second parameter of the technique, that is more than 1024 character long
So when calling the log_rudder from the reporting context, string name is too long and it is ignored.

Actions

Copy link

Updated by Nicolas CHARLES over 3 years ago

Target version changed from 6.1.4 to 6.0.9

The reason is the way the classes are defined in the rudder_reporting bundle: we define a dummy_class prefix with all params of the technique, truncate to 1000 characters, and then call all the reporting method with class_prefix + generic method name and parameter and state, which can be larger than 23 character (like : file_lines_present_etc_pki_ca_trust_source_anchors_lo_crt_noop )

solution would be to have a dedicated bundle for na reporting, that would handle itself all this

Actions

Copy link

Updated by PB LO over 3 years ago

Ok. Changed to copy file from shared folder instead of using a parameter.
It's works. Conditions are working.

Thank you !

Actions

Copy link

Updated by Nicolas CHARLES over 3 years ago

Subject changed from Techniques with conditions on tasks, report "missing" parts on the dashboard to Techniques with conditions on tasks with very long parameters, report "missing" parts on the dashboard
Category changed from Techniques to Web - Config management

clarifying title

Actions

Copy link

#10

Updated by Nicolas CHARLES over 3 years ago

Status changed from New to In progress
Assignee set to Nicolas CHARLES

Actions

Copy link

#11

Updated by Nicolas CHARLES over 3 years ago

Status changed from In progress to Pending technical review
Assignee changed from Nicolas CHARLES to Alexis Mousset
Pull Request set to https://github.com/Normation/rudder/pull/3169

PR https://github.com/Normation/rudder/pull/3169

Actions

Copy link

#12

Updated by Nicolas CHARLES over 3 years ago

Subject changed from Techniques with conditions on tasks with very long parameters, report "missing" parts on the dashboard to Techniques with conditions on tasks with very long parameters report "missing" parts on the dashboard

it also causes in Inform output

2020-08-10T19:23:19+00:00  warning: Skipping adding class [test_condition_rudder_reporting_eth__qkjfhksdjhfksjfhksjhfskljfhskqhfkshfkjqshfkjhskfjhsqkfhsqkjfhklsqjfhklsjhfksljhfksjhfksqjhfksljfhksljhfksjhksjhfksjhfkshksjhfhhhhhhhhhhhhhhhhhhhhhhhhhhfffffffffffffffffffffffffffffffffffffffffffffffffffjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxlllllllllllllllllllllllllllllllllllllllllllbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeemmmmmmmmmmmmmmmmmmm_command_execution__usr_bin_update_ca_certificates_noop] as its name is equal or longer than 1024

as class_prefix is truncate to 1000, and command_execution_usr_bin_update_ca_certificates_noop is longer than 23 characters

Actions

Copy link

#13