Bug #2168: List of Policy Instances is not a link in popup of applicable policies when accepting a new node - Rudder - Issue Tracker

Actions

Copy link

Bug #2168

closed

List of Policy Instances is not a link in popup of applicable policies when accepting a new node

Added by Jonathan CLARKE almost 13 years ago. Updated almost 12 years ago.

Status:

Released

Priority:

Assignee:

Nicolas CHARLES

Category:

Web - Nodes & inventories

Target version:

2.4.2

Pull Request:

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

When accepting a pending node, there is a magnifying glass icon that shows a popup of all CRs that would apply to this node if it is accepted. In this popup, the list of CR contains a column for the PIs in the CR. Normally, when there are several PIs, this is a link that shows a popup. In this view, it is not a link.

Files

Screenshot.png (77.6 KB) Screenshot.png

Jonathan CLARKE, 2012-01-12 18:46

Actions

Copy link

Updated by Jonathan CLARKE almost 13 years ago

Target version changed from 2.3.6 to 2.3.7

Actions

Copy link

Updated by Nicolas PERRON over 12 years ago

Target version changed from 2.3.7 to 2.3.8

Actions

Copy link

Updated by Nicolas PERRON over 12 years ago

Shouldn't we assign Arthur on this bug ?

Actions

Copy link

Updated by Jonathan CLARKE over 12 years ago

Priority changed from 3 to 4

I think there's a problem with this, that is that we cannot have a popup inside a popup. Does anyone have any other ideas of how to present this information?

Either way, it's not too urgent, as we can always get this information from the Configuration management screen.

Actions

Copy link

Updated by Jonathan CLARKE over 12 years ago

Target version changed from 2.3.8 to 2.3.9

Actions

Copy link

Updated by Jean VILVER about 12 years ago

Status changed from New to Discussion
Assignee set to Jonathan CLARKE

For 2.4, I think a solution would be to not show a popup when we click on the directive button, but to instead show the popup content in a subsection between "Node Summary" and "Hardware" (or elsewhere).

The advantage to that solution is that all the information on a new node is display the same way.

What do you think?

Actions

Copy link

Updated by Jonathan CLARKE about 12 years ago

Assignee changed from Jonathan CLARKE to Jean VILVER

Jean VILVER wrote:

For 2.4, I think a solution would be to not show a popup when we click on the directive button, but to instead show the popup content in a subsection between "Node Summary" and "Hardware" (or elsewhere).

The advantage to that solution is that all the information on a new node is display the same way.

What do you think?

If I understand correctly, your suggestion is to:

Remove the column "Directive" from the table of pending nodes
Add a tab to the detailed view of a pending node, along side "Node Summary", "Hardware", "Network", etc to contain the same information

If so, I agree, and I think this is a good idea. This would ideally be in the same tab position as the "Reports" tab for accepted nodes, since the content will be similar. It could be called "Configuration policy".

Actions

Copy link

Updated by Nicolas PERRON about 12 years ago

Assignee deleted (~~Jean VILVER~~)
Target version changed from 2.3.9 to 2.3.10

Actions

Copy link

Updated by François ARMAND almost 12 years ago

Assignee set to Jonathan CLARKE

That was not corrected in 2.4, so we still have the bug.

I propose to move the last comment as a new feature request, and as a bug correction for that one, to simply:

remove link for groups and directives
add a link for the rule name, that will redirect to the rule (and so the user is able to see the rule (even in a new tab so that he does not loose its context)

It's clearly not ideal, but I don't see what we can do that is not disruptive for 2.4.

Actions

Copy link

#10

Updated by Jonathan CLARKE almost 12 years ago

Assignee changed from Jonathan CLARKE to François ARMAND

François ARMAND wrote:

That was not corrected in 2.4, so we still have the bug.

I propose to move the last comment as a new feature request, and as a bug correction for that one, to simply:

remove link for groups and directives

add a link for the rule name, that will redirect to the rule (and so the user is able to see the rule (even in a new tab so that he does not loose its context)

It's clearly not ideal, but I don't see what we can do that is not disruptive for 2.4.

Works for me. Please go ahead :)

Actions

Copy link

#11

Updated by François ARMAND almost 12 years ago

Assignee changed from François ARMAND to Jonathan CLARKE

I don't see that as a blocker for 2.4.0 as it's a long time pending bug, so I will do it but we should not wait for that one for 2.4.0~RC2 (nor final).

Actions

Copy link

#12

Updated by Jonathan CLARKE almost 12 years ago

Assignee changed from Jonathan CLARKE to François ARMAND
Target version changed from 2.3.10 to 61

François ARMAND wrote:

I don't see that as a blocker for 2.4.0 as it's a long time pending bug, so I will do it but we should not wait for that one for 2.4.0~RC2 (nor final).

OK, but can you please create the user story you suggested and link it from here?

I'm leaving this assigned to you, there is nothing I can do here.

Actions

Copy link

#13