Bug #2168
closed
List of Policy Instances is not a link in popup of applicable policies when accepting a new node
Added by Jonathan CLARKE almost 13 years ago. Updated almost 12 years ago.
Description
When accepting a pending node, there is a magnifying glass icon that shows a popup of all CRs that would apply to this node if it is accepted. In this popup, the list of CR contains a column for the PIs in the CR. Normally, when there are several PIs, this is a link that shows a popup. In this view, it is not a link.
Files
Updated by Jonathan CLARKE almost 13 years ago
- Target version changed from 2.3.6 to 2.3.7
Updated by Nicolas PERRON over 12 years ago
- Target version changed from 2.3.7 to 2.3.8
Updated by Nicolas PERRON over 12 years ago
Shouldn't we assign Arthur on this bug ?
Updated by Jonathan CLARKE over 12 years ago
- Priority changed from 3 to 4
I think there's a problem with this, that is that we cannot have a popup inside a popup. Does anyone have any other ideas of how to present this information?
Either way, it's not too urgent, as we can always get this information from the Configuration management screen.
Updated by Jonathan CLARKE over 12 years ago
- Target version changed from 2.3.8 to 2.3.9
Updated by Jean VILVER about 12 years ago
- Status changed from New to Discussion
- Assignee set to Jonathan CLARKE
For 2.4, I think a solution would be to not show a popup when we click on the directive button, but to instead show the popup content in a subsection between "Node Summary" and "Hardware" (or elsewhere).
The advantage to that solution is that all the information on a new node is display the same way.
What do you think?
Updated by Jonathan CLARKE about 12 years ago
- Assignee changed from Jonathan CLARKE to Jean VILVER
Jean VILVER wrote:
If I understand correctly, your suggestion is to:For 2.4, I think a solution would be to not show a popup when we click on the directive button, but to instead show the popup content in a subsection between "Node Summary" and "Hardware" (or elsewhere).
The advantage to that solution is that all the information on a new node is display the same way.
What do you think?
- Remove the column "Directive" from the table of pending nodes
- Add a tab to the detailed view of a pending node, along side "Node Summary", "Hardware", "Network", etc to contain the same information
If so, I agree, and I think this is a good idea. This would ideally be in the same tab position as the "Reports" tab for accepted nodes, since the content will be similar. It could be called "Configuration policy".
Updated by Nicolas PERRON about 12 years ago
- Assignee deleted (
Jean VILVER) - Target version changed from 2.3.9 to 2.3.10
Updated by François ARMAND almost 12 years ago
- Assignee set to Jonathan CLARKE
That was not corrected in 2.4, so we still have the bug.
I propose to move the last comment as a new feature request, and as a bug correction for that one, to simply:
- remove link for groups and directives
- add a link for the rule name, that will redirect to the rule (and so the user is able to see the rule (even in a new tab so that he does not loose its context)
It's clearly not ideal, but I don't see what we can do that is not disruptive for 2.4.
Updated by Jonathan CLARKE almost 12 years ago
- Assignee changed from Jonathan CLARKE to François ARMAND
François ARMAND wrote:
That was not corrected in 2.4, so we still have the bug.
I propose to move the last comment as a new feature request, and as a bug correction for that one, to simply:
- remove link for groups and directives
- add a link for the rule name, that will redirect to the rule (and so the user is able to see the rule (even in a new tab so that he does not loose its context)
It's clearly not ideal, but I don't see what we can do that is not disruptive for 2.4.
Works for me. Please go ahead :)
Updated by François ARMAND almost 12 years ago
- Assignee changed from François ARMAND to Jonathan CLARKE
I don't see that as a blocker for 2.4.0 as it's a long time pending bug, so I will do it but we should not wait for that one for 2.4.0~RC2 (nor final).
Updated by Jonathan CLARKE almost 12 years ago
- Assignee changed from Jonathan CLARKE to François ARMAND
- Target version changed from 2.3.10 to 61
François ARMAND wrote:
I don't see that as a blocker for 2.4.0 as it's a long time pending bug, so I will do it but we should not wait for that one for 2.4.0~RC2 (nor final).
OK, but can you please create the user story you suggested and link it from here?
I'm leaving this assigned to you, there is nothing I can do here.
Updated by François ARMAND almost 12 years ago
- Status changed from Discussion to 8
The other user story is #3060
Updated by François ARMAND almost 12 years ago
- Assignee changed from François ARMAND to Arthur ANGLADE
Updated by Arthur ANGLADE almost 12 years ago
- Status changed from 8 to In progress
Updated by François ARMAND almost 12 years ago
- Target version changed from 61 to 2.4.2
Updated by Arthur ANGLADE almost 12 years ago
- Status changed from In progress to Pending technical review
- % Done changed from 0 to 100
here is the pull request : https://github.com/Normation/rudder/pull/53
Updated by Arthur ANGLADE almost 12 years ago
- Assignee changed from Arthur ANGLADE to Nicolas CHARLES
Updated by Arthur ANGLADE almost 12 years ago
- Status changed from Pending technical review to Pending release
Applied in changeset a82456496dfd9cf03ba91425d1a8a4567dd9d967.
Updated by Nicolas CHARLES almost 12 years ago
Applied in changeset 9d800f06d7882f375977138954c2797af71a9040.
Updated by Nicolas PERRON almost 12 years ago
- Status changed from Pending release to Released