Rudder plugins » Change validation

note that group changes are direct with a validated user

This is a tricky bug, the probleme is in method combine[T](checkFn:(ValidationNeeded, EventActor, T) => Box[Boolean], checks: Seq[ValidationNeeded], actor: EventActor, change: T): Box[WorkflowService]
In this method, we will iterate over checks who are implementation of ValidationNeeded that defines their own logic for validation through method forDirective, forGlobalParam etc.
checkFn:(ValidationNeeded, EventActor, T) => Box[Boolean] is the method that we use to validate, there are for* method

The problem was when iterates over checks if a check return true we don't look at the other check. In the case of validated user, the check was not performed. We should check in priority if there is a validated user before iterating or looking for other checks. If a user is validated, he is no subject to any workflow, so we have to check it before everything.
We decided to remove the logic of validated user from ValidationNeeded, because it adds complexity to understand, and as for* methods are identical we decided to check directly validated users in combine method

This bug has been fixed in Rudder plugin change-validation v7.3.0.rc1-2.1