Bug #24111: Pending deployment action are completely messed up - Change validation - Issue Tracker

Actions

Copy link

Bug #24111

closed

Pending deployment action are completely messed up

Added by Vincent MEMBRÉ about 1 year ago. Updated about 1 year ago.

Status:

Released

Priority:

N/A

Assignee:

François ARMAND

Target version:

Rudder plugins - 7.3

Pull Request:

https://github.com/Normation/rudder-p...

Severity:

Major - prevents use of part of Rudder | no simple workaround

UX impact:

I hate Rudder for that

User visibility:

Operational - other Techniques | Rudder settings | Plugins

Effort required:

Priority:

132

Name check:

To do

Fix check:

To do

Regression:

Description

There is two action in pending validation "Deploy" popup from "Pending Deployment"

Pending Deployment
Deploy

Deploy (due to changes in #22601) change from step "penfing validation" to Deploy, but this fails because we are in "pending deployent" state. This fails with following message

2024-01-30 23:51:34+0100 ERROR change-validation - Cannot change status of ChangeRequest '15': it has the status 'Pending deployment' but we were expecting 'Pending validation'. Perhaps someone else changed it concurrently?

This may have been fixed by changes in #22993, but this add an action "Pending Deployment" Which in fact set the status from pending deployment to deploy, but why would click on this ? it makes you think that you do no change the step ? that's crazy

Fix is to go back to one step, that does the right thing

Related issues 2 (0 open — 2 closed)