Rudder

I prefer diff_only_background_differences.png most !But I'm not Jon :)

Jonathan CLARKE wrote:

Thanks for looking into this Jean.

Without hesitation, I prefer diff_option_by_default.png. The background colour makes it very clear what lines we need to be looking at. The "+/-" at the beginning of the line are important for the convention to tell readers "this is a diff". The coloured text helps make it easier on the eyes, in my opinion.

Caution, Red on Red and Green on Green are very poor in term of readability (I have difficulty to read the green on green line)

Nicolas CHARLES wrote:

Jonathan CLARKE wrote:

Thanks for looking into this Jean.

Without hesitation, I prefer diff_option_by_default.png. The background colour makes it very clear what lines we need to be looking at. The "+/-" at the beginning of the line are important for the convention to tell readers "this is a diff". The coloured text helps make it easier on the eyes, in my opinion.

Caution, Red on Red and Green on Green are very poor in term of readability (I have difficulty to read the green on green line)

OK, I see what you mean. How about we keep the black text, but use the softer background colours from diff_option_by_default?

that's ok for me, thank you

Jean VILVER wrote:

Jonathan CLARKE wrote:

[...]
OK, I see what you mean. How about we keep the black text, but use the softer background colours from diff_option_by_default?

The result is in the attached image. But it doesn't feel green without the green text of diff_option_by_default.

Perfect. Thanks Jean!