Project

General

Profile

Actions
Copy link

Architecture #3122

closed

Architecture #3118: Upgrade Jgit

update Jgit

Added by Vincent MEMBRÉ almost 12 years ago. Updated over 9 years ago.

Status:
Released
Priority:
2
Assignee:
François ARMAND
Category:
Architecture - Dependencies
Target version:
2.5.0~beta1
Pull Request:
Effort required:
Name check:
Fix check:
Regression:

Description

we should at least upgrade Jgit to version 2.1 to make #3102 work.

pull request https://github.com/Normation/cf-clerk/pull/2

There is also a 2.2 release made in mid-december 2012 :

I made another pull request for it : https://github.com/Normation/cf-clerk/pull/3

Actions
Copy link
 #1

Updated by Vincent MEMBRÉ almost 12 years ago

  • Subject changed from update jgit to 2.1 to update Jgit
  • Description updated (diff)
Actions
Copy link
 #2

Updated by François ARMAND almost 12 years ago

  • Status changed from Pending technical review to Discussion
  • Assignee changed from François ARMAND to Vincent MEMBRÉ

Why two pull request with two versions?
Does the most recent JGit version is OK (no API breakage, no behaviour modification, that kind of things ?) If so, we just have to go with it.

Actions
Copy link
 #3

Updated by Vincent MEMBRÉ almost 12 years ago

As the latest version is two weeks old only and there is not much return from it, I thought it would not be good to update directly to that version.

I haven't found any problem with 2.2, and I don't think there is, but I have not enough hindsight to be sure...

So I made two pull requests to have the choice beetween the two.

Actions
Copy link
 #4

Updated by Vincent MEMBRÉ almost 12 years ago

  • Assignee changed from Vincent MEMBRÉ to François ARMAND
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ almost 12 years ago

There is no Breaking change in 2.2 (mostly new possibilities, and debug)

Actions
Copy link
 #6

Updated by François ARMAND almost 12 years ago

OK, so let's go for 2.1, we will switch to 2.2 for Rudder 2.6.

Thanks !

Actions
Copy link
 #7

Updated by Vincent MEMBRÉ almost 12 years ago

  • Status changed from Discussion to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:2db4d3f73c588ba3bd17a5309231b4fb726f8ffd.

Actions
Copy link
 #8

Updated by Matthieu CERDA almost 12 years ago

  • Status changed from Pending release to Released
Actions
Copy link
 #9

Updated by Benoît PECCATTE over 9 years ago

  • Tracker changed from 6 to Architecture
Actions
Copy link

Also available in: Atom PDF