Project

General

Profile

Actions
Copy link

Bug #3170

closed

Techniques 'Zypper Package Manager Configuration' and 'RUG / YaST package manager configuration (ZMD)': Broken Reporting when configuration more than one repository which should not be added

Added by Nicolas PERRON over 11 years ago. Updated about 9 years ago.

Status:
Released
Priority:
1
Assignee:
Nicolas CHARLES
Category:
Techniques
Target version:
2.3.11
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

When using the Technique Zypper Package Manager Configuration, it seems that the only way to have a successful reporting is to configure no more than one repository and which should not be added into zypper.

Here are the differents behaviour:
  • If one repository is set and should be added => All reporting of Rudder will be in an Unkown state
  • If one repository is set and should not be added => Success
  • If several repositories are set and should be added => reporting about the Directive is in a No Response state and no report appears in the Technical log of the node about this Directive
  • If several repositories are set and should not be added => reporting about the Directive is in a No Response state and no report appears in the Technical log of the node about this Directive

Pull Request URL: https://github.com/Normation/rudder-techniques/pull/59 https://github.com/Normation/rudder-techniques/pull/46

Edit: This bug is present in the Technique 'RUG / YaST package manager configuration (ZMD)' too.

Files

Download all files
ZypperConfigBug.png (86.5 KB) ZypperConfigBug.png Nicolas PERRON, 2013-01-10 15:59
zypperPackageManagerSettingsFix3170.patch (8.12 KB) zypperPackageManagerSettingsFix3170.patch Nicolas PERRON, 2013-01-10 16:47

Related issues 1 (0 open — 1 closed)

Related to Rudder - User story #3253: Techniques "RUG / YaST package manager configuration (ZMD)" and "Zypper package manager configuration" should be split in three: two for configuring Rug /YaST and Zypper, the last one to configure repositoriesReleasedNicolas PERRON2013-02-11Actions
Actions
Copy link
 #1

Updated by Nicolas PERRON over 11 years ago

  • Category set to Techniques
  • Assignee set to Nicolas PERRON
  • Priority changed from N/A to 1
  • Target version set to 2.3.10
Actions
Copy link
 #2

Updated by Nicolas PERRON over 11 years ago

Here is an extract from tail -f /var/log/rudder/reports/all.log | grep Repository on the server with two Repositories to set:

2013-01-10T16:04:23+01:00 sles-11-sp1-64 rudder[27535]:  R: @@zypperPackageManagerSettings@@result_success@@f6061429-1565-4373-9a6f-e9c253a9cc91@@98874df5-9099-4632-bea5-075154ae4361@@6f6061429-1565-4373-9a6f-e9c253a9cc91@@98874df5-9099-4632-bea5-075154ae4361@@6@@Repository@@Rudder Project@@2013-01-10 16:04:17+01:00##59e66fe7-7f0e-497d-8055-a103116b4a08@#The Zypper source Rudder Project was already here. Skipping...
2013-01-10T16:04:23+01:00 sles-11-sp1-64 rudder[27535]:  R: @@zypperPackageManagerSettings@@result_success@@f6061429-1565-4373-9a6f-e9c253a9cc91@@98874df5-9099-4632-bea5-075154ae4361@@6f6061429-1565-4373-9a6f-e9c253a9cc91@@98874df5-9099-4632-bea5-075154ae4361@@6@@Repository@@Rudder Project Unstable@@2013-01-10 16:04:17+01:00##59e66fe7-7f0e-497d-8055-a103116b4a08@#The Zypper source Rudder Project Unstable was already here. Skipping...
Actions
Copy link
 #3

Updated by Nicolas PERRON over 11 years ago

The bug seems to come from a misuse of a the Technique TrackingKey. Here is a fix for branch 2.3

Actions
Copy link
 #4

Updated by Nicolas PERRON about 11 years ago

  • Description updated (diff)
  • Status changed from New to Pending technical review
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Nicolas PERRON about 11 years ago

  • Assignee changed from Nicolas PERRON to Jonathan CLARKE

Jon, could you review this pull request, please ?

Actions
Copy link
 #6

Updated by Nicolas PERRON about 11 years ago

  • Status changed from Pending technical review to Discussion

I suppose the pull request can be cancelled.

The reporting can't work since the Tracking Key used is based on a multivalued component which can be null:
  • If the tracking key is null, Rudder will not be aware of relations between Directives and reports received.
  • There is no any chance to have reports on the none multivalued components
The solution is to split this Technique into two:
  • One Technique which will do the job for adding repositories
  • Another Technique which will set general settings for zypper (install recommends)
I wonder: shouldn't we rename the Technique if the goals are altered ?
  • Zypper package manager configuration rename into Zypper repositories management
  • Add Zypper settings management

Jon, what do you think about ?

Actions
Copy link
 #7

Updated by Jonathan CLARKE about 11 years ago

Nicolas PERRON wrote:

I suppose the pull request can be cancelled.

No need for that, just update it.

The reporting can't work since the Tracking Key used is based on a multivalued component which can be null:
  • If the tracking key is null, Rudder will not be aware of relations between Directives and reports received.
  • There is no any chance to have reports on the none multivalued components
The solution is to split this Technique into two:
  • One Technique which will do the job for adding repositories
  • Another Technique which will set general settings for zypper (install recommends)
I wonder: shouldn't we rename the Technique if the goals are altered ?
  • Zypper package manager configuration rename into Zypper repositories management

Yep, sounds good.

  • Add Zypper settings management

I'd prefer "Zypper package manager settings".

Actions
Copy link
 #8

Updated by Matthieu CERDA about 11 years ago

  • Target version changed from 2.3.10 to 2.3.11
Actions
Copy link
 #9

Updated by Nicolas PERRON about 11 years ago

  • Subject changed from Technique Zypper Package Manager Configuration: Broken Reporting when configuration more than one repository which should not be added to Techniques 'Zypper Package Manager Configuration' and 'RUG / YaST package manager configuration (ZMD)': Broken Reporting when configuration more than one repository which should not be added
  • Description updated (diff)
  • Status changed from Discussion to Pending technical review
  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES

Updated the title of the ticket. This bug appears not only on 'Zypper Package Manager Configuration' but with 'RUG / YaST package manager configuration (ZMD) too.

Pull Request URL updated: https://github.com/Normation/rudder-techniques/pull/59

Nicolas, could you review it please ?

Actions
Copy link
 #10

Updated by Nicolas PERRON about 11 years ago

Nicolas PERRON wrote:

Updated the title of the ticket. This bug appears not only on 'Zypper Package Manager Configuration' but with 'RUG / YaST package manager configuration (ZMD) too.

Pull Request URL updated: https://github.com/Normation/rudder-techniques/pull/59

Nicolas, could you review it please ?

Reuse and update previous Pull Request instead: https://github.com/Normation/rudder-techniques/pull/46

Nicolas, could you review it, please ?

Actions
Copy link
 #11

Updated by Nicolas PERRON about 11 years ago

  • Description updated (diff)

Pull Request URL updated on description.

Actions
Copy link
 #12

Updated by Nicolas PERRON about 11 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:f7cb8c5f1357e9d064d93ae85e914e4c83177532.

Actions
Copy link
 #13

Updated by Nicolas CHARLES about 11 years ago

Applied in changeset commit:3025177c70f40490de20b0938e4eb456e2d5db0e.

Actions
Copy link
 #14

Updated by Nicolas PERRON about 11 years ago

Applied in changeset commit:98701b512e2dd63ca982dc6d0851a031277e0bc5.

Actions
Copy link
 #15

Updated by Nicolas PERRON about 11 years ago

Applied in changeset commit:ba2d070f49fd3a720679c23e2040c67993c3600b.

Actions
Copy link
 #16

Updated by Nicolas PERRON about 11 years ago

Applied in changeset commit:f6eed4b11b64fdcda160cc066c8b2ab20c783986.

Actions
Copy link
 #17

Updated by Matthieu CERDA about 11 years ago

  • Status changed from Pending release to Released

This ticket has been adressed in the 2.3.11 release of Rudder.

The ChangeLog is available here: http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog23

Actions
Copy link
 #18

Updated by Benoît PECCATTE about 9 years ago

  • Project changed from 24 to Rudder
  • Category changed from Techniques to Techniques
Actions
Copy link

Also available in: Atom PDF