Bug #3487: Several Techniques are missing package_patch_command - Rudder - Issue Tracker

Actions

Copy link

Bug #3487

closed

Several Techniques are missing package_patch_command

Added by Nicolas CHARLES over 11 years ago. Updated almost 10 years ago.

Status:

Released

Priority:

1 (highest)

Assignee:

Nicolas PERRON

Category:

Techniques

Target version:

2.6.0~rc1

Pull Request:

https://github.com/Normation/rudder-t...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

CFEngine 3.4 is much stricter on the syntax, and we need to define a package_patch_command in the rpmPackageInstallation for it to work

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Jonathan CLARKE over 11 years ago

Target version changed from 2.3.12 to 2.6.0~rc1

We only introduced CFEngine 3.4 in Rudder 2.6, no need to make unneeded changes in older versions.

Actions

Copy link

Updated by Nicolas PERRON over 11 years ago

Status changed from New to Discussion
Assignee set to Jonathan CLARKE

I don't see any problem during execution of rpmPackageInstallation.cf with CFEngine 3.4.4... and I see that #3489 pretends to solve the problem of #3487. So, I suppose We have nothing to do here, right ?

Actions

Copy link

Updated by Jonathan CLARKE over 11 years ago

I just tested this on CentOS 6 and there most definitely is a problem. The Technique returns an error, and in verbose output you can see this:

rudder>    =========================================================
rudder>    packages in bundle check_rpm_package_installation (1)
rudder>    =========================================================
rudder> 
rudder> !! Dependency conflict: package_patch_command is not used, but package_patch_arch_regex is defined.
rudder>  ?> defining persistent promise result class rpm_package_install_failed_0

Actions

Copy link

Updated by Jonathan CLARKE over 11 years ago

Status changed from Discussion to In progress

This works again if we remove all the patch definitions from the package_method. Since we don't use this feature.

Actions

Copy link

Updated by Jonathan CLARKE over 11 years ago

Subject changed from rpmPackageInstallation is missing package_patch_command to Several Techniques are missing package_patch_command

Actually this error would likely occur in several Techniques that use package_method bodies. I'm fixing them all.

To do this, I have to update cfengine_stdlib.cf to include extra lines. Given the late hour in the release cycle, I don't want to change the whole file, so I've just added in the changes from this commit: https://github.com/cfengine/core/commit/4c90924e3515189696c7760cfc080a27ac8ff37b.

Actions

Copy link

Updated by Jonathan CLARKE over 11 years ago

Status changed from In progress to Pending technical review
Assignee changed from Jonathan CLARKE to Nicolas PERRON
Pull Request set to https://github.com/Normation/rudder-techniques/pull/101