Bug #3487
closed
Several Techniques are missing package_patch_command
Added by Nicolas CHARLES over 11 years ago.
Updated almost 10 years ago.
Description
CFEngine 3.4 is much stricter on the syntax, and we need to define a package_patch_command in the rpmPackageInstallation for it to work
- Target version changed from 2.3.12 to 2.6.0~rc1
We only introduced CFEngine 3.4 in Rudder 2.6, no need to make unneeded changes in older versions.
- Status changed from New to Discussion
- Assignee set to Jonathan CLARKE
I don't see any problem during execution of rpmPackageInstallation.cf with CFEngine 3.4.4... and I see that #3489 pretends to solve the problem of #3487. So, I suppose We have nothing to do here, right ?
I just tested this on CentOS 6 and there most definitely is a problem. The Technique returns an error, and in verbose output you can see this:
rudder> =========================================================
rudder> packages in bundle check_rpm_package_installation (1)
rudder> =========================================================
rudder>
rudder> !! Dependency conflict: package_patch_command is not used, but package_patch_arch_regex is defined.
rudder> ?> defining persistent promise result class rpm_package_install_failed_0
- Status changed from Discussion to In progress
This works again if we remove all the patch definitions from the package_method. Since we don't use this feature.
- Subject changed from rpmPackageInstallation is missing package_patch_command to Several Techniques are missing package_patch_command
Actually this error would likely occur in several Techniques that use package_method bodies. I'm fixing them all.
To do this, I have to update cfengine_stdlib.cf to include extra lines. Given the late hour in the release cycle, I don't want to change the whole file, so I've just added in the changes from this commit: https://github.com/cfengine/core/commit/4c90924e3515189696c7760cfc080a27ac8ff37b.
- Status changed from In progress to Pending technical review
- Assignee changed from Jonathan CLARKE to Nicolas PERRON
- Pull Request set to https://github.com/Normation/rudder-techniques/pull/101
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset commit:356d228b33f85d46486b34aa2d87cae16a9d0c73.
Applied in changeset commit:ced3f0bbb3353965f72dcc8b1a329d370f4535d1.
Applied in changeset commit:674c8530fca9dc6156e9e586108af8b59572faf4.
- Status changed from Pending release to Released
- Project changed from 24 to Rudder
- Category changed from Techniques to Techniques
Also available in: Atom
PDF
Updated by Jonathan CLARKE 
Updated by Nicolas PERRON 
Updated by