Project

General

Profile

Actions
Copy link

Bug #3539

closed

Policy Template "Download A File": The inputs of the Technique are not checked by regexp to prevent wrong URL or destination format

Added by François ARMAND over 11 years ago. Updated almost 10 years ago.

Status:
Released
Priority:
2
Assignee:
Jonathan CLARKE
Category:
Techniques
Target version:
2.3.13
Pull Request:
https://github.com/Normation/rudder-t...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

In Rudder 2.5.2, when I put "Download a file" in fields "URL to download file from" and "Absolute path to download file to on a node", I don't get an error on the directive form, but I get one when deploying.

Actions
Copy link
 #1

Updated by Nicolas PERRON over 11 years ago

  • Target version changed from 2.5.3 to 2.5.4
Actions
Copy link
 #2

Updated by Nicolas CHARLES over 11 years ago

  • Status changed from 8 to In progress
  • Assignee set to Nicolas CHARLES
  • Target version changed from 2.5.4 to 2.3.13

The problem is with the field "Absolute path to download file to on a node" that should be a valid path
fileexists requieres the regexp ?(/.*) (but it wouldn't match windows paths...)

Actions
Copy link
 #3

Updated by Nicolas CHARLES over 11 years ago

Ok, enterprise accepts Windows path; so we should have a regexp accepting windows or unixes paths
(/.*)|([a-zA-Z]:[/\\].*)

Actions
Copy link
 #4

Updated by Nicolas CHARLES over 11 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE
  • % Done changed from 0 to 100
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/127
Actions
Copy link
 #5

Updated by Nicolas PERRON over 11 years ago

it is OK to me. It is good to have added a check on it.

Actions
Copy link
 #6

Updated by Nicolas CHARLES over 11 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:f6f4a4e3c939b1e86fa0c9795eec7d9410bc01e3.

Actions
Copy link
 #7

Updated by Nicolas PERRON over 11 years ago

Applied in changeset commit:3a9e0df6321ce289bf4e87a1f142f04486c355f1.

Actions
Copy link
 #8

Updated by Nicolas PERRON over 11 years ago

  • Subject changed from DownloadAFile does not check inputs to Policy Template "Download A File": The inputs of the Technique are not checked by regexp to prevent wrong URL or destination format
Actions
Copy link
 #9

Updated by Nicolas PERRON over 11 years ago

  • Status changed from Pending release to Released
Actions
Copy link
 #10

Updated by Benoît PECCATTE almost 10 years ago

  • Project changed from 24 to Rudder
  • Category changed from Techniques to Techniques
Actions
Copy link

Also available in: Atom PDF