Bug #3539
closed
Policy Template "Download A File": The inputs of the Technique are not checked by regexp to prevent wrong URL or destination format
Added by François ARMAND over 11 years ago.
Updated over 9 years ago.
Description
In Rudder 2.5.2, when I put "Download a file" in fields "URL to download file from" and "Absolute path to download file to on a node", I don't get an error on the directive form, but I get one when deploying.
- Target version changed from 2.5.3 to 2.5.4
- Status changed from 8 to In progress
- Assignee set to Nicolas CHARLES
- Target version changed from 2.5.4 to 2.3.13
The problem is with the field "Absolute path to download file to on a node" that should be a valid path
fileexists requieres the regexp ?(/.*) (but it wouldn't match windows paths...)
Ok, enterprise accepts Windows path; so we should have a regexp accepting windows or unixes paths
(/.*)|([a-zA-Z]:[/\\].*)
- Status changed from In progress to Pending technical review
- Assignee changed from Nicolas CHARLES to Jonathan CLARKE
- % Done changed from 0 to 100
- Pull Request set to https://github.com/Normation/rudder-techniques/pull/127
it is OK to me. It is good to have added a check on it.
- Status changed from Pending technical review to Pending release
Applied in changeset commit:f6f4a4e3c939b1e86fa0c9795eec7d9410bc01e3.
Applied in changeset commit:3a9e0df6321ce289bf4e87a1f142f04486c355f1.
- Subject changed from DownloadAFile does not check inputs to Policy Template "Download A File": The inputs of the Technique are not checked by regexp to prevent wrong URL or destination format
- Status changed from Pending release to Released
- Project changed from 24 to Rudder
- Category changed from Techniques to Techniques
Also available in: Atom
PDF
Updated by Nicolas PERRON 
Updated by 
Updated by