Project

General

Profile

Bug #3741

Technique "Name resolution": Regexp to check value of Nameserver does not allow the use of variable

Added by Nicolas PERRON over 6 years ago. Updated about 4 years ago.

Status:
Released
Priority:
N/A
Category:
Techniques
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

We should be able to use CFEngine variables in the Nameserver option of the Technique Name resolution. Actually, this is not possible since the regexp prevent from using other values than IP adresses:

Please modify Nameserver to match the requested format : You must enter a valid IP


Subtasks

Bug #7806: Technique "Name resolution": Regexp to check value of Nameserver does not allow the use of variable - version 3.0 (branch 3.0)ReleasedNicolas CHARLESActions

Associated revisions

Revision 415c4482 (diff)
Added by Jonathan CLARKE about 4 years ago

Fixes #3741: Technique "Name resolution": Regexp to check value of Nameserver does not allow the use of variable

Revision bf0d0567
Added by Nicolas CHARLES about 4 years ago

Merge pull request #851 from jooooooon/bug_3741/technique_name_resolution_regexp_to_check_value_of_nameserver_does_not_allow_the_use_of_variable

Fixes #3741: Technique \"Name resolution\": Regexp to check value of Nameserver does not allow the use of variable

History

#1

Updated by Nicolas PERRON over 6 years ago

  • Target version changed from 2.4.7 to 2.4.8
#2

Updated by Vincent MEMBRÉ over 6 years ago

  • Status changed from New to 8
  • Priority changed from N/A to 1

The regexp should not accept cfengine variable, because we can't check their value in Rudder and they may not respect the regexp.

We should try to replace all cfengine variable by their value (only if there is a regexp defined) before the validation,

this exclude direct cfengine variable ($sys.xxx) because Rudder can't check them.

Variable defined using Technique "CFEngine variable definition" may be checked, but I don't know if this is something we want to do

Inventory variable should be checked too, but I don't know how and which way to validate it (maybe the value does not exists for that node, maybe it is not a valide value,)

The easiest way is to use global parameters, global parameters can be replaced easily. and checked easily (replace the global parameters by its value)

#3

Updated by Vincent MEMBRÉ over 6 years ago

Another solution would be to accept any variable, but to display a warning explaining that Rudder can't validate that value, and let you use cfengine varaible at your own risk

#4

Updated by Nicolas PERRON over 6 years ago

  • Target version changed from 2.4.8 to 2.4.9
#5

Updated by Nicolas PERRON over 6 years ago

  • Target version changed from 2.4.9 to 2.4.10
#6

Updated by Nicolas PERRON over 6 years ago

  • Target version changed from 2.4.10 to 2.4.11
#7

Updated by Nicolas PERRON over 6 years ago

  • Target version changed from 2.4.11 to 2.4.12
#8

Updated by Nicolas PERRON over 6 years ago

  • Target version changed from 2.4.12 to 2.4.13
#9

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 2.4.13 to 2.6.11

Since 2.4 is not maintained anymore, retargeting to branch 2.6

#10

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 2.6.11 to 2.6.12
#11

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 2.6.12 to 2.6.13
#12

Updated by Nicolas PERRON almost 6 years ago

  • Status changed from 8 to Discussion
  • Assignee set to Jonathan CLARKE

Vincent MEMBRÉ wrote:

Another solution would be to accept any variable, but to display a warning explaining that Rudder can't validate that value, and let you use cfengine varaible at your own risk

I suppose this solution is better, what's your opinion Jon ?

#13

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 2.6.13 to 2.6.14
#14

Updated by Jonathan CLARKE over 5 years ago

  • Target version changed from 2.6.14 to 2.6.16
#15

Updated by Jonathan CLARKE over 5 years ago

  • Target version changed from 2.6.16 to 2.6.17
#16

Updated by Nicolas PERRON over 5 years ago

  • Target version changed from 2.6.17 to 2.6.18
#17

Updated by Matthieu CERDA over 5 years ago

  • Target version changed from 2.6.18 to 2.6.19
#18

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 2.6.19 to 2.6.20
#19

Updated by François ARMAND about 5 years ago

  • Assignee deleted (Jonathan CLARKE)
  • Target version changed from 2.6.20 to 2.10.10
#20

Updated by Vincent MEMBRÉ about 5 years ago

  • Target version changed from 2.10.10 to 2.10.11
#21

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 2.10.11 to 2.10.12
#22

Updated by Benoît PECCATTE almost 5 years ago

  • Project changed from Techniques to Rudder
  • Category set to Techniques
#23

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 2.10.12 to 2.10.13
#24

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 2.10.13 to 2.10.14
#25

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 2.10.14 to 2.10.15
#26

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 2.10.15 to 2.10.16
#27

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 2.10.16 to 2.10.17
#28

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 2.10.17 to 2.10.18
#29

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 2.10.18 to 2.10.19
#30

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 2.10.19 to 2.10.20
#31

Updated by Vincent MEMBRÉ about 4 years ago

  • Target version changed from 2.10.20 to 2.11.18
#32

Updated by Jonathan CLARKE about 4 years ago

  • Status changed from Discussion to In progress
  • Assignee set to Jonathan CLARKE
#33

Updated by Jonathan CLARKE about 4 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/851
#34

Updated by Jonathan CLARKE about 4 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
#35

Updated by Vincent MEMBRÉ about 4 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.18, 3.0.13, 3.1.6 and 3.2.0 which were released today.

Also available in: Atom PDF