Project

General

Profile

Actions
Copy link

Bug #3741

closed

Technique "Name resolution": Regexp to check value of Nameserver does not allow the use of variable

Bug #3741: Technique "Name resolution": Regexp to check value of Nameserver does not allow the use of variable

Added by Nicolas PERRON almost 13 years ago. Updated over 10 years ago.

Status:
Released
Priority:
N/A
Assignee:
Nicolas CHARLES
Category:
Techniques
Target version:
2.11.18
Pull Request:
https://github.com/Normation/rudder-t...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

We should be able to use CFEngine variables in the Nameserver option of the Technique Name resolution. Actually, this is not possible since the regexp prevent from using other values than IP adresses:

Please modify Nameserver to match the requested format : You must enter a valid IP

Subtasks 1 (0 open — 1 closed)

Bug #7806: Technique "Name resolution": Regexp to check value of Nameserver does not allow the use of variable - version 3.0 (branch 3.0)ReleasedNicolas CHARLESActions

Updated by Nicolas PERRON almost 13 years ago Actions
Copy link
 #1

  • Target version changed from 2.4.7 to 2.4.8

Updated by Vincent MEMBRÉ almost 13 years ago Actions
Copy link
 #2

  • Status changed from New to 8
  • Priority changed from N/A to 1 (highest)

The regexp should not accept cfengine variable, because we can't check their value in Rudder and they may not respect the regexp.

We should try to replace all cfengine variable by their value (only if there is a regexp defined) before the validation,

this exclude direct cfengine variable ($sys.xxx) because Rudder can't check them.

Variable defined using Technique "CFEngine variable definition" may be checked, but I don't know if this is something we want to do

Inventory variable should be checked too, but I don't know how and which way to validate it (maybe the value does not exists for that node, maybe it is not a valide value,)

The easiest way is to use global parameters, global parameters can be replaced easily. and checked easily (replace the global parameters by its value)

Updated by Vincent MEMBRÉ almost 13 years ago Actions
Copy link
 #3

Another solution would be to accept any variable, but to display a warning explaining that Rudder can't validate that value, and let you use cfengine varaible at your own risk

Updated by Nicolas PERRON almost 13 years ago Actions
Copy link
 #4

  • Target version changed from 2.4.8 to 2.4.9

Updated by Nicolas PERRON almost 13 years ago Actions
Copy link
 #5

  • Target version changed from 2.4.9 to 2.4.10

Updated by Nicolas PERRON almost 13 years ago Actions
Copy link
 #6

  • Target version changed from 2.4.10 to 2.4.11

Updated by Nicolas PERRON almost 13 years ago Actions
Copy link
 #7

  • Target version changed from 2.4.11 to 2.4.12

Updated by Nicolas PERRON over 12 years ago Actions
Copy link
 #8

  • Target version changed from 2.4.12 to 2.4.13

Updated by Vincent MEMBRÉ over 12 years ago Actions
Copy link
 #9

  • Target version changed from 2.4.13 to 2.6.11

Since 2.4 is not maintained anymore, retargeting to branch 2.6

Updated by Vincent MEMBRÉ over 12 years ago Actions
Copy link
 #10

  • Target version changed from 2.6.11 to 2.6.12

Updated by Vincent MEMBRÉ over 12 years ago Actions
Copy link
 #11

  • Target version changed from 2.6.12 to 2.6.13

Updated by Nicolas PERRON about 12 years ago Actions
Copy link
 #12

  • Status changed from 8 to Discussion
  • Assignee set to Jonathan CLARKE

Vincent MEMBRÉ wrote:

Another solution would be to accept any variable, but to display a warning explaining that Rudder can't validate that value, and let you use cfengine varaible at your own risk

I suppose this solution is better, what's your opinion Jon ?

Updated by Vincent MEMBRÉ about 12 years ago Actions
Copy link
 #13

  • Target version changed from 2.6.13 to 2.6.14

Updated by Jonathan CLARKE about 12 years ago Actions
Copy link
 #14

  • Target version changed from 2.6.14 to 2.6.16

Updated by Jonathan CLARKE about 12 years ago Actions
Copy link
 #15

  • Target version changed from 2.6.16 to 2.6.17

Updated by Nicolas PERRON almost 12 years ago Actions
Copy link
 #16

  • Target version changed from 2.6.17 to 2.6.18

Updated by Matthieu CERDA almost 12 years ago Actions
Copy link
 #17

  • Target version changed from 2.6.18 to 2.6.19

Updated by Vincent MEMBRÉ over 11 years ago Actions
Copy link
 #18

  • Target version changed from 2.6.19 to 2.6.20

Updated by François ARMAND over 11 years ago Actions
Copy link
 #19

  • Assignee deleted (Jonathan CLARKE)
  • Target version changed from 2.6.20 to 2.10.10

Updated by Vincent MEMBRÉ over 11 years ago Actions
Copy link
 #20

  • Target version changed from 2.10.10 to 2.10.11

Updated by Vincent MEMBRÉ over 11 years ago Actions
Copy link
 #21

  • Target version changed from 2.10.11 to 2.10.12

Updated by Benoît PECCATTE over 11 years ago Actions
Copy link
 #22

  • Project changed from 24 to Rudder
  • Category set to Techniques

Updated by Vincent MEMBRÉ over 11 years ago Actions
Copy link
 #23

  • Target version changed from 2.10.12 to 2.10.13

Updated by Vincent MEMBRÉ over 11 years ago Actions
Copy link
 #24

  • Target version changed from 2.10.13 to 2.10.14

Updated by Vincent MEMBRÉ about 11 years ago Actions
Copy link
 #25

  • Target version changed from 2.10.14 to 2.10.15

Updated by Vincent MEMBRÉ about 11 years ago Actions
Copy link
 #26

  • Target version changed from 2.10.15 to 2.10.16

Updated by Vincent MEMBRÉ almost 11 years ago Actions
Copy link
 #27

  • Target version changed from 2.10.16 to 2.10.17

Updated by Vincent MEMBRÉ almost 11 years ago Actions
Copy link
 #28

  • Target version changed from 2.10.17 to 2.10.18

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #29

  • Target version changed from 2.10.18 to 2.10.19

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #30

  • Target version changed from 2.10.19 to 2.10.20

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #31

  • Target version changed from 2.10.20 to 2.11.18

Updated by Jonathan CLARKE over 10 years ago Actions
Copy link
 #32

  • Status changed from Discussion to In progress
  • Assignee set to Jonathan CLARKE

Updated by Jonathan CLARKE over 10 years ago Actions
Copy link
 #33

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/851

Updated by Jonathan CLARKE over 10 years ago Actions
Copy link
 #34

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #35

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.18, 3.0.13, 3.1.6 and 3.2.0 which were released today.

Actions
Copy link

Also available in: PDF Atom