User story #3948
closed
User story #3937: When saving a Rule without target groups or directives, display a warning message
Add warning when saving a Rule with no groups nor directives
Added by Vincent MEMBRÉ about 11 years ago.
Updated over 9 years ago.
Category:
Web - Config management
Description
When modifying a Rule and removing all directives/groups, the Rules is not applied.
But the popup says that everything is fine and that the Rule will be applied.
This is wrong!
As Jon said in #3937 :
This user story should add a small warning to the confirmation popup, so it reads somethings like this:
--------------8<----------------------
Rule saved successfully*
WARNING: This Rule is not applied to any Groups. No configuration policy will be deployed.**
--------------8<----------------------
Don't change this text, leave it as is, I just don't remember it right now
If there are groups but not Directives, this should read "This Rule does not have any Directives to apply. No configuration policy will be deployed."
- Status changed from In progress to Discussion
- Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE
Only have one question : If there is no groups and no directives linked to the Rule the popup should display one or to message ?
ie:
Rule saved successfully
WARNING: This Rule is not applied to any Groups. No configuration policy will be deployed.
WARNING: This Rule does not have any Directives to apply. No configuration policy will be deployed.
or
Rule saved successfully
WARNING: This Rule is not applied to any Groups and does not have any Directives to apply. No configuration policy will be deployed.
I think the first one is better (line too long and complicated for the last one).
Jon what do you think of it ?
- Status changed from Discussion to 10
- Pull Request set to https://github.com/Normation/rudder/pull/319
Adding pull request,
need fonctionnal review before tech review.
- Status changed from 10 to In progress
- Assignee changed from Jonathan CLARKE to Vincent MEMBRÉ
I discussed with Jon about which warning to use and we finally choose the one line style:
WARNING: This Rule is not applied to any Groups and does not have any Directives to apply. No configuration policy will be deployed
- Status changed from In progress to 10
- Assignee changed from Vincent MEMBRÉ to François ARMAND
- Status changed from 10 to Pending technical review
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
- Status changed from Pending release to Released
This bug has been fixed in Rudder 2.8.0~beta1, which was released today.
Check out:
- Tracker changed from Enhancement to User story
Also available in: Atom
PDF