Project

General

Profile

Actions

User story #4268

closed

Implement a generic_method for insuring that a section contains exactly a block

Added by Nicolas CHARLES almost 9 years ago. Updated 4 months ago.

Status:
Released
Priority:
N/A
Assignee:
Matthieu CERDA
Category:
Generic methods
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Regression:

Description

This generic_method would create the section if it doesn't exist, or enforce this section if it does exist

Actions #1

Updated by Nicolas CHARLES almost 9 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE

PR is there
https://github.com/Normation/ncf/pull/21/files

However, the test fails as the diff cannot find source nor destination file.
Any idea why it fail ?

/usr/bin/diff: /home/nicolas/dev/ncf/tests/acceptance/workdir/__30_generic_methods_file_ensure_block_in_section_cf/tmp/reference: No such file or directory
/usr/bin/diff: /home/nicolas/dev/ncf/tests/acceptance/workdir/__30_generic_methods_file_ensure_block_in_section_cf/tmp/test: No such file or directory

but they are here:
./workdir/__30_generic_methods_file_ensure_block_in_section_cf/tmp
./workdir/__30_generic_methods_file_ensure_block_in_section_cf/tmp/reference
./workdir/__30_generic_methods_file_ensure_block_in_section_cf/tmp/test
Actions #2

Updated by Nicolas CHARLES almost 9 years ago

ok, it was an error in the classes
PR updated !

Actions #3

Updated by Nicolas CHARLES almost 9 years ago

  • Assignee changed from Jonathan CLARKE to Matthieu CERDA
Actions #4

Updated by Nicolas CHARLES almost 9 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:24038f65685c4b02be915c9512a67476e98b5b6e.

Actions #5

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 2.9.0~rc1 to 2.9.0~rc2
Actions #6

Updated by François ARMAND over 8 years ago

  • Status changed from Pending release to Released
Actions #7

Updated by Benoît PECCATTE over 7 years ago

  • Target version changed from 2.9.0~rc2 to 0.x
Actions #8

Updated by Benoît PECCATTE over 7 years ago

  • Tracker changed from Enhancement to User story
Actions #9

Updated by Alexis Mousset 4 months ago

  • Target version changed from 0.x to ncf-0.x
Actions #10

Updated by Alexis Mousset 4 months ago

  • Project changed from 41 to Rudder
  • Category set to Generic methods
Actions

Also available in: Atom PDF