Project

General

Profile

Actions
Copy link

Bug #4492

closed

When accepting several nodes, one policy generation is triggered for each of them

Added by Vincent MEMBRÉ almost 11 years ago. Updated over 10 years ago.

Status:
Released
Priority:
2
Assignee:
Nicolas CHARLES
Category:
Web - Nodes & inventories
Target version:
2.6.12
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

WHen you accept more than one node, a deployment is launched for every node.

This is totally useless, and only one deployment should be launched once every node is accepted.

If a deployment succeed while nodes are accepted it will be not be complete (miss some nodes) and replaced right after.

Moreover, a deployment is started when nodes are refused, what make no sens, because no modification on the configuration of the infrastructure can happen on that case.

Actions
Copy link
 #1

Updated by Vincent MEMBRÉ over 10 years ago

  • Target version changed from 2.6.11 to 2.6.12
Actions
Copy link
 #2

Updated by François ARMAND over 10 years ago

I believe it is more than a bug for 2.6, so if it's more than 2 lines, it should bo to 2.10.

Actions
Copy link
 #3

Updated by François ARMAND over 10 years ago

In fact, the correction is trivial and also correct the fact that policies are regenerated when refusing nodes, so correcting it to 2.6.

Actions
Copy link
 #4

Updated by François ARMAND over 10 years ago

  • Status changed from New to In progress
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
Actions
Copy link
 #5

Updated by François ARMAND over 10 years ago

  • Subject changed from When accepting several nodes, there is as many deployment launched to When accepting several nodes, one policy generation is triggered for each of them
Actions
Copy link
 #6

Updated by François ARMAND over 10 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder/pull/467
Actions
Copy link
 #7

Updated by François ARMAND over 10 years ago

  • Description updated (diff)
Actions
Copy link
 #8

Updated by Nicolas CHARLES over 10 years ago

  • Status changed from Pending technical review to In progress
  • Assignee changed from Nicolas CHARLES to François ARMAND

Francois,

I guess you forgot a "if" condition, or either you defined unused variables

Actions
Copy link
 #9

Updated by François ARMAND over 10 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Nicolas CHARLES

PR updated

Actions
Copy link
 #10

Updated by François ARMAND over 10 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions
Copy link
 #12

Updated by Vincent MEMBRÉ over 10 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.6.12, which was released today.
Check out:

Actions
Copy link

Also available in: Atom PDF