Bug #4494: Accumulation of cf-agent processes due to locking on CFEngine tcdb lock file - Rudder - Issue Tracker

Actions

Copy link

Bug #4494

closed

Accumulation of cf-agent processes due to locking on CFEngine tcdb lock file

Added by Nicolas CHARLES almost 11 years ago. Updated over 9 years ago.

Status:

Released

Priority:

1 (highest)

Assignee:

Jonathan CLARKE

Category:

Web - Config management

Target version:

2.8.3

Pull Request:

https://github.com/Normation/rudder-p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

Sometimes, agents get stuck because they all try to lock /var/rudder/cfengine-community/state/cf_lock.tcdb.lock, resulting in a deadlock

In #3928, we implemented a workaround based on the number of agent running, to kill them all if necessary, but here we'll check the age of
/var/rudder/cfengine_community/last_successful_inputs_update

If it is older than 10 minutes, then the agent is stuck, and we kill the .lock file

It happens mainly with cfengine 3.5.x, so targeting to Rudder 2.8

Related issues 4 (0 open — 4 closed)

Actions

Copy link

Updated by Nicolas CHARLES almost 11 years ago

Status changed from In progress to Pending technical review
Assignee changed from Nicolas CHARLES to Jonathan CLARKE
Pull Request set to https://github.com/Normation/rudder-packages/pull/223

https://github.com/Normation/rudder-packages/pull/223

Actions

Copy link

Updated by Jonathan CLARKE over 10 years ago

Assignee changed from Jonathan CLARKE to Nicolas CHARLES

Actions

Copy link

Updated by Nicolas CHARLES over 10 years ago

Status changed from Pending technical review to Pending release
% Done changed from 0 to 100

Applied in changeset packages:commit:73b07fdcb42e49a17f32275229feaedbdd257f1c.

Actions

Copy link

Updated by Nicolas CHARLES over 10 years ago

Applied in changeset packages:commit:df74f7b8232514f01f56fdb880d4c3fe4c41d887.

Actions

Copy link

Updated by Vincent MEMBRÉ over 10 years ago

Status changed from Pending release to Discussion
Assignee changed from Nicolas CHARLES to Vincent MEMBRÉ

A syntax error in the script prevent installation of rudder-agent:

/opt/rudder/bin/check-rudder-agent: 68: Syntax error: "elif" unexpected
Setting up rudder-inventory-ldap (2.8.3~rc1~git201402240715-squeeze0) ...
dpkg: error processing rudder-agent (--configure):
 subprocess installed post-installation script returned error exit status 2

If block needs a command before elif and there is not. adding ':' ("do nothing" in bash, alias to 'true') fix the issue

Actions

Copy link

Updated by Vincent MEMBRÉ over 10 years ago

Status changed from Discussion to Pending technical review
Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE
Pull Request changed from https://github.com/Normation/rudder-packages/pull/223 to https://github.com/Normation/rudder-packages/pull/228

PR here: https://github.com/Normation/rudder-packages/pull/228

Actions

Copy link

Updated by Vincent MEMBRÉ over 10 years ago

Status changed from Pending technical review to Pending release

Applied in changeset packages:commit:db4524e1ae306973e9532c72fb24e84384e9e62b.

Actions

Copy link

Updated by Jonathan CLARKE over 10 years ago

Applied in changeset packages:commit:c7488cb738e1f151d17c0cdd8d283194ebe8bb69.

Actions

Copy link

Updated by Vincent MEMBRÉ over 10 years ago

Subject changed from Accumulation of agent due to locking on /var/rudder/cfengine-community/state/cf_lock.tcdb.lock to Accumulation of agent due to locking on CFEngine tcdb lock file

Actions

Copy link

#10

Updated by Vincent MEMBRÉ over 10 years ago

Category changed from 13 to 14

Actions

Copy link

#11

Updated by Vincent MEMBRÉ over 10 years ago

Subject changed from Accumulation of agent due to locking on CFEngine tcdb lock file to Accumulation of cf-agent processes due to locking on CFEngine tcdb lock file

Actions

Copy link

#12