Bug #4706: Reloading Technique library doesn't apply changes to generated promises - Rudder - Issue Tracker

Actions

Copy link

Bug #4706

closed

Reloading Technique library doesn't apply changes to generated promises

Added by Jonathan CLARKE over 10 years ago. Updated over 10 years ago.

Status:

Released

Priority:

Assignee:

Nicolas CHARLES

Category:

Web - Maintenance

Target version:

2.10.1

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

I have seen this happen several times now, using 2.10 (it may exist on older versions, but I don't use them regularly, so I don't know).

To reproduce:

Go to a running Rudder server
cd /var/rudder/configuration-repository/techniques/
Edit the contents of a .st file
git add <that .st file> && git commit -m "Test change"
Go back to the web interface, Administration tab, click on "Reload techniques"
Watch the promise generation happen

Then, you can go and see the .cf file generated from the .st file you changed. It won't contain the change.

The simple workaround is to go to the web interface, Administration tab, click on "Clear caches", and the newly generated files will contain the change.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by François ARMAND over 10 years ago

Subject changed from Reloading Technique library doesn't apply changes to generated promises to Reloading Technique library doesn't apply changes to generated system promises
Status changed from 8 to Discussion
Assignee changed from François ARMAND to Nicolas CHARLES

More information: the problem is on system techniques.

The cause is that reload technique only reload user technique (more preciselly, ignore system technique).

Nicolas, I think you were aware of that. Do you know if there is a reason, or if it's just a bug ?

Thanks,

Actions

Copy link

Updated by François ARMAND over 10 years ago

Subject changed from Reloading Technique library doesn't apply changes to generated system promises to Reloading Technique library doesn't apply changes to generated promises
Assignee changed from Nicolas CHARLES to François ARMAND

More tests by Jon shows that it is not specific to system techniques. So Nicolas, I think my question was irrelevant.

Actions

Copy link

Updated by Matthieu CERDA over 10 years ago

The problem has been encountered again while helping someone to update his system AND normal Techniques, this problem is annoying. Maybe a quick win would be to trigger a clear caches too when reloading promises ?

Of course, the underlying issue would still require a fix.

Actions

Copy link

Updated by Nicolas CHARLES over 10 years ago

Status changed from Discussion to In progress
Assignee changed from François ARMAND to Nicolas CHARLES

it's quite hard to reproduce, hence the lack of fix yet.
I'll try to find a solution/workaround for this one.

Actions

Copy link

Updated by François ARMAND over 10 years ago

Status changed from In progress to Discussion
Assignee changed from Nicolas CHARLES to François ARMAND

So, I succeeded in reproducing it for motd.

I didn't find the root cause, but at least I can assure that:

- for the corresponding activeTechnique, the acceptationTimestamp is correctly updated,
- the techniqueLibraryVersion is correctly updated,
- the technique update is correctly logged (in debug level)
- the technique update correctly fire checks on directives using it

Actions

Copy link