User story #5303: Use empty ("") value in place of null for variable that has the attribute maybeempty - Rudder - Issue Tracker

Actions

Copy link

User story #5303

closed

User story #3014: Optionnal variables should not be nulled (if they are not system variables)

Use empty ("") value in place of null for variable that has the attribute maybeempty

Added by Nicolas CHARLES over 9 years ago. Updated about 9 years ago.

Status:

Released

Priority:

N/A

Assignee:

François ARMAND

Category:

Web - Config management

Target version:

3.0.0~beta1

Pull Request:

UX impact:

Suggestion strength:

User visibility:

Effort required:

Name check:

Fix check:

Regression:

Description

Don't write anymore null variable in place of empty variable if a variable is empty, and not a system variable

Actions

Copy link

Updated by Nicolas CHARLES over 9 years ago

Status changed from New to Pending technical review
Assignee changed from Nicolas CHARLES to François ARMAND

https://github.com/Normation/cf-clerk/pull/50

Actions

Copy link

Updated by Nicolas CHARLES over 9 years ago

Status changed from Pending technical review to Pending release
% Done changed from 0 to 100

Applied in changeset clerk:commit:8869dafa62ec6c732ae7a5066354b9f8803d24d3.

Actions

Copy link

Updated by François ARMAND over 9 years ago

Applied in changeset clerk:commit:8c5961683a6db74902d12ee86ec81a095cb6f26e.

Actions

Copy link

Updated by François ARMAND over 9 years ago

Subject changed from Don't write null variable that has the attribute maybeempty is they are not system variable to Use empty ("") value in place of null for variable that has the attribute maybeempty

Today, when a variable that may be empty is actually empty, we set it's value to 'null'. This is against general working of scripting and cause unessecary test condition. So we will use the empty string '""' in place.

One exception: for internal, system variable, the meaning of null is special and is used to remove part of technique code, a little like a C preprocessor compiler and #IFDEF. So, for system variable, an empty value is kept to "null" until we evolve to a better way of dealing with that.

Actions

Copy link