Project

General

Profile

Actions

Bug #5444

closed

Inconsistency between advertised error class definition and actual class definition, and wrong use of class lead to no error reporting

Added by Nicolas CHARLES about 8 years ago. Updated 4 months ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Regression:

Description

Most generic methods say they define a class with suffix _error if they fail, but this class is never defined.
We have either _not_ok, or failed, but no _error

What is worse is that rudder_logger is based in the _error class, so we NEVER have error reports in Rudder


Subtasks 1 (0 open1 closed)

Bug #5766: classes_generic_return_code in ncf_lib doesn't define _error classesReleasedBenoît PECCATTEActions
Actions #1

Updated by Nicolas CHARLES about 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/ncf/pull/114
Actions #2

Updated by Matthieu C about 8 years ago

It seems that bundle agent rudder_common_reports_generic in rudder_stdlib still checks for _error suffix

Actions #3

Updated by Nicolas CHARLES about 8 years ago

indeed, that is why we will define the _error as well

Actions #4

Updated by Nicolas CHARLES about 8 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:53a8030a7ba76e3ca952e9e9cd82915a2fd1b5ac.

Actions #5

Updated by Jonathan CLARKE about 8 years ago

Applied in changeset commit:7fe3c22db4b0a9d2bc87357c3a79cd10fea5e45f.

Actions #6

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released
Actions #7

Updated by Alexis Mousset 4 months ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions #8

Updated by Alexis Mousset 4 months ago

  • Project changed from 41 to Rudder
  • Category set to Generic methods
Actions

Also available in: Atom PDF