Bug #5528: Get system serial number output from inventory though API - Rudder - Issue Tracker

Actions

Copy link

Bug #5528

closed

Get system serial number output from inventory though API

Added by Olivier Mauras over 10 years ago. Updated about 10 years ago.

Status:

Released

Priority:

Assignee:

Nicolas CHARLES

Category:

API

Target version:

2.11.3

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

Hello,

It seems that even fetching full inventory doesn't output the system serial number.
Could you please add a way to get it?

Thanks,
Olivier

Edit, FAR: for reference, both the "serial" and "manufacturer" fields viewable in the node inventory details, in the [General] section since Rudder 2.11 are concerned.

Actions

Copy link

Updated by Matthieu CERDA over 10 years ago

Status changed from New to 8
Assignee set to François ARMAND
Priority changed from N/A to 3

Giving this to FAR, he knows what's what about this :)

Actions

Copy link

Updated by François ARMAND over 10 years ago

Description updated (diff)
Target version set to 2.11.3

Actions

Copy link

Updated by François ARMAND over 10 years ago

Tracker changed from User story to Bug

This seems to be a bug, because we added these information in 2.11 in the main panel but not in the API.

Actions

Copy link

Updated by François ARMAND over 10 years ago

Pull Request set to https://github.com/Normation/rudder/pull/613

Proposed place for these information:

- 1/ in the main (first) level:

"data": {
    "nodes": [
    {
        "id": "32e45242-5571-4d9b-87ae-07b02b6f8fff",
        "hostname": "node1.rudder.local",
        ....
        "manufacturer": "innotek GmbH",
        "systemSerialNumber": "0",
        ....
        "os": {
            ....
        }  
        ... other caracteristics ...
    }
  }

2/ in the "machine"

"data": {
    "nodes": [
    {
        "id": "32e45242-5571-4d9b-87ae-07b02b6f8fff",
        "hostname": "node1.rudder.local",
        ....
        ....
        "os": {
            ....
        }  
        "machine": {
          "id": "883EC5E5-5614-4F4F-881C-AE2AF8952DF4",
          "type": "Virtual",
          "provider": "vbox",
          "manufacturer": "innotek GmbH",
          "serialNumber": "0" 
        },
        ... other caracteristics ...
    }
  }

1/ map the most closely the logic of the node details. But 2/ seems more logical: these fields are optionnal and are actual caracteristic of the hardware.

For the naming scheme, I think "manufacturer" is OK. For the "system serial number", I think the whole name is needed if at the root level (case 1), but "machine.serialNumber" is shorter/better.

So I would go for 2, and the PR available here allow to test that solution: https://github.com/Normation/rudder/pull/613

Actions

Copy link