Bug #5799: system technique can only setup log settings *once* on syslog-ng - Rudder - Issue Tracker

Actions

Copy link

Bug #5799

closed

system technique can only setup log settings once on syslog-ng

Added by Florian Heigl over 9 years ago. Updated over 8 years ago.

Status:

Released

Priority:

Assignee:

Jonathan CLARKE

Category:

System techniques

Target version:

2.6.20

Pull Request:

https://github.com/Normation/rudder-t...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

The code to edit the respective syslog config files (i.e. syslog-ng) is not imdempotent.

If the entry is updated, it will at best create a second one.

The effect: i.e. the tcp/udp decision has to be made prior to clients applying the system techniques for the first time or it will be wrong on all clients and stay like it.

If they are meant to only run once in a lifetime, then please close and disregard.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Nicolas CHARLES over 9 years ago

Hi Florian,

The configuration is expected to be idempotent, it looks at the server it sends to, and compares to the server it should send it to, but the comparaison checks also for udp/tcp (actually, always tcp unless on old syslog)

the issue here is that you changed the format, breaking the comparision

we should update the comparision to handle this case, but this does not happen in "standart" usage.

Note: rsyslog should be immune to this issue

Actions

Copy link

Updated by Florian Heigl over 9 years ago

Nuuuuu?

I don; think i changed the format, i'll paste examples after reproducing. Only changed the word tcp to the word udp.

Actions

Copy link

Updated by Nicolas CHARLES over 9 years ago

Oh, i must have not been clear.
Changing the work tcp to udp changes the format of the line for the comparision (it looks with a strict regex at lines that contains tcp)

Actions

Copy link

Updated by Matthieu CERDA over 9 years ago

Status changed from New to Pending technical review
Assignee set to Jonathan CLARKE
Priority changed from N/A to 3
Target version set to 2.6.20
% Done changed from 0 to 100
Pull Request set to https://github.com/Normation/rudder-techniques/pull/593

PR is ready: https://github.com/Normation/rudder-techniques/pull/593

Well, I see no "clean" way of doing this...

      "syslog_conf_comment"   string => "# Autogenerated by rudder, do not edit${const.n}";

      "syslog_ng_conf_prefix" string => "filter f_local_rudder{facility(local6) and program(\"rudder.*\");};destination loghost {tcp(\"";
      "syslog_ng_conf_suffix" string => "\" port (&SYSLOGPORT&));};log {source(${syslog_ng_source});filter(f_local_rudder);destination(loghost);";
      "syslog_ng_conf_final"  string => "flags(final);};";

      "syslog_ng_conf"        string => concat("${syslog_conf_comment}", "${syslog_ng_conf_prefix}", "${server_info.cfserved}", "${syslog_ng_conf_suffix}", "${syslog_ng_conf_final}");
      "syslog_ng_conf_regex"  string => concat("filter\ f\_local\_rudder\{facility\(local6\)\ and\ program\(\"rudder\.\*\"\)\;\}\;destination\ loghost\ \{(tcp|udp)\(\"", "[^\"]+", escape("${syslog_ng_conf_suffix}"), ".*");

I hope syslog-ng will support on all OS versions we work with a syslog-ng.d dir or something, so we can do something cleaner...

Actions

Copy link