Bug #5825: rudder-jetty and rudder-inventory-ldap init scripts can fail when killall is not available - Rudder - Issue Tracker

Custom queries

Bugs triage
CS - by assignee
CS - by priority
CS - to review
My TR
Need technical review
Open bugs (all)
Open bugs (UI - UX)
Open UX defects (all)
Opened by users

Actions

Copy link

Bug #5825

closed

rudder-jetty and rudder-inventory-ldap init scripts can fail when killall is not available

Bug #5825: rudder-jetty and rudder-inventory-ldap init scripts can fail when killall is not available

Added by Nicolas CHARLES almost 12 years ago. Updated almost 11 years ago.

Status:

Released

Priority:

N/A

Assignee:

Jonathan CLARKE

Category:

Web - Config management

Target version:

3.0.0~beta2

Pull Request:

https://github.com/Normation/rudder-p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

On a fresh Debian, killall is not installed, and I suspect that it is the same on other system (it does have killall5 thought)

After promises generation, the server attempt to run /usr/bin/killall, and fails

We shoud rather execute

kill -SIGHUP `pidof cf-serverd`

Subtasks 1 (0 open — 1 closed)

Bug #5913: Adapt killall to kill/pidof combination in source rudder-web.properties

Released

Jonathan CLARKE

Actions

Related issues 3 (0 open — 3 closed)

Related to Rudder - Bug #5574: Have a configuration property to execute a post promise writing hook	Released	Jonathan CLARKE	Actions
Related to Rudder - Bug #6051: Warning after policy generation, /bin/pidof does not exists	Released	Matthieu CERDA	Actions
Related to Rudder - Bug #7515: rudder-agent and rudder-slapd init scripts may fail to stop services if killall is missing or misbehaving	Released	Benoît PECCATTE	Actions

Issue # Delay: days Cancel Multiple values allowed (comma separated).

History
Notes
Property changes
Associated revisions

Updated by Jonathan CLARKE almost 12 years ago Actions
Copy link
#1

Status changed from New to 8
Priority changed from N/A to 1 (highest)
Parent task deleted (~~#5574~~)

This was introduced by #5574.

Updated by Benoît PECCATTE almost 12 years ago Actions
Copy link
#2

Status changed from 8 to Pending technical review
Assignee changed from Nicolas CHARLES to Jonathan CLARKE

PR https://github.com/Normation/rudder-packages/pull/548

Updated by Benoît PECCATTE almost 12 years ago Actions
Copy link
#3

Status changed from Pending technical review to Pending release
% Done changed from 0 to 100

Applied in changeset packages:rudder-packages|commit:0e075be1b37b71dfb296acc448e3bac26dd73b4c.

Updated by Jonathan CLARKE almost 12 years ago Actions
Copy link
#4

Applied in changeset packages:rudder-packages|commit:7cc290fc2fbe9a1e6553fc5afcfa8695d75a5e94.

Updated by Vincent MEMBRÉ almost 12 years ago Actions
Copy link
#5

Pull Request set to https://github.com/Normation/rudder-packages/pull/548

Updated by Vincent MEMBRÉ over 11 years ago Actions
Copy link
#6

Subject changed from killall is not available on all system, hence the command to reload the server after promises generation may fail to The command to reload the server after promises generation fails when killall is not available

Updated by Vincent MEMBRÉ over 11 years ago Actions
Copy link
#7

Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.5, which was released today (16/12/14)

Announcement 2.11
Changelog 2.11
Download information: https://www.rudder-project.org/site/get-rudder/downloads/

Updated by Benoît PECCATTE over 11 years ago Actions
Copy link
#8

Category changed from 14 to Web - Config management

Updated by Jonathan CLARKE almost 11 years ago Actions
Copy link
#9

Target version changed from 2.11.5 to 3.0.0~beta2

This ticket was erroneously marked as fixed in the 2.11 branch. However, it was only fixed in the 3.0 branch, and is part of the 3.0.0 release.

Updated by Jonathan CLARKE almost 11 years ago Actions
Copy link
#10

Related to Bug #7515: rudder-agent and rudder-slapd init scripts may fail to stop services if killall is missing or misbehaving added

Updated by Vincent MEMBRÉ almost 11 years ago Actions
Copy link
#11

In fact it should have been done in 2.11, since it was already present there, it was fixed in 2.11 by #6051 and released in 2.11.7

Updated by Jonathan CLARKE almost 11 years ago Actions
Copy link
#12

Subject changed from The command to reload the server after promises generation fails when killall is not available to rudder-jetty and rudder-inventory-ldap init scripts can fail when killall is not available

Vincent MEMBRÉ wrote:

In fact it should have been done in 2.11, since it was already present there, it was fixed in 2.11 by #6051 and released in 2.11.7

Actually, these bugs fix different things - #6051 only changes the command used to reload cf-serverd, but #5825 also fixes init scripts to use pidof instead of killall. Since #6051 is in 2.11, the changelog will correctly reflect this change in 2.11, and this ticket should be in the 3.0 changelog only.

I have renamed this ticket to reflect this change.

Updated by Vincent MEMBRÉ almost 11 years ago Actions
Copy link
#13

You are right, #6051 fix only a subpart of #5825 ( cf-serverd ) that should have been done in 2.11 from the beginning in another issue

I added #5825 in 3.0.0~beta2 changelog

Updated by Vincent MEMBRÉ almost 11 years ago Actions
Copy link
#14

And #7515 will backport (with improvements) this fix in 2.11 for init scripts,

Actions

Copy link

Also available in: PDF Atom

Project

General

Profile

Rudder

Custom queries

Bug #5825

rudder-jetty and rudder-inventory-ldap init scripts can fail when killall is not available

Updated by Jonathan CLARKE almost 12 years ago Actions
Copy link
#1

Updated by Benoît PECCATTE almost 12 years ago Actions
Copy link
#2

Updated by Benoît PECCATTE almost 12 years ago Actions
Copy link
#3

Updated by Jonathan CLARKE almost 12 years ago Actions
Copy link
#4

Updated by Vincent MEMBRÉ almost 12 years ago Actions
Copy link
#5

Updated by Vincent MEMBRÉ over 11 years ago Actions
Copy link
#6

Updated by Vincent MEMBRÉ over 11 years ago Actions
Copy link
#7

Updated by Benoît PECCATTE over 11 years ago Actions
Copy link
#8

Updated by Jonathan CLARKE almost 11 years ago Actions
Copy link
#9

Updated by Jonathan CLARKE almost 11 years ago Actions
Copy link
#10

Updated by Vincent MEMBRÉ almost 11 years ago Actions
Copy link
#11

Updated by Jonathan CLARKE almost 11 years ago Actions
Copy link
#12

Updated by Vincent MEMBRÉ almost 11 years ago Actions
Copy link
#13

Updated by Vincent MEMBRÉ almost 11 years ago Actions
Copy link
#14

Project

General

Profile

Rudder

Custom queries

Bug #5825

rudder-jetty and rudder-inventory-ldap init scripts can fail when killall is not available

Updated by Jonathan CLARKE almost 12 years ago ActionsCopy link #1

Updated by Benoît PECCATTE almost 12 years ago ActionsCopy link #2

Updated by Benoît PECCATTE almost 12 years ago ActionsCopy link #3

Updated by Jonathan CLARKE almost 12 years ago ActionsCopy link #4

Updated by Vincent MEMBRÉ almost 12 years ago ActionsCopy link #5

Updated by Vincent MEMBRÉ over 11 years ago ActionsCopy link #6

Updated by Vincent MEMBRÉ over 11 years ago ActionsCopy link #7

Updated by Benoît PECCATTE over 11 years ago ActionsCopy link #8

Updated by Jonathan CLARKE almost 11 years ago ActionsCopy link #9

Updated by Jonathan CLARKE almost 11 years ago ActionsCopy link #10

Updated by Vincent MEMBRÉ almost 11 years ago ActionsCopy link #11

Updated by Jonathan CLARKE almost 11 years ago ActionsCopy link #12

Updated by Vincent MEMBRÉ almost 11 years ago ActionsCopy link #13

Updated by Vincent MEMBRÉ almost 11 years ago ActionsCopy link #14

Updated by Jonathan CLARKE almost 12 years ago Actions
Copy link
#1

Updated by Benoît PECCATTE almost 12 years ago Actions
Copy link
#2

Updated by Benoît PECCATTE almost 12 years ago Actions
Copy link
#3

Updated by Jonathan CLARKE almost 12 years ago Actions
Copy link
#4

Updated by Vincent MEMBRÉ almost 12 years ago Actions
Copy link
#5

Updated by Vincent MEMBRÉ over 11 years ago Actions
Copy link
#6

Updated by Vincent MEMBRÉ over 11 years ago Actions
Copy link
#7

Updated by Benoît PECCATTE over 11 years ago Actions
Copy link
#8

Updated by Jonathan CLARKE almost 11 years ago Actions
Copy link
#9

Updated by Jonathan CLARKE almost 11 years ago Actions
Copy link
#10

Updated by Vincent MEMBRÉ almost 11 years ago Actions
Copy link
#11

Updated by Jonathan CLARKE almost 11 years ago Actions
Copy link
#12

Updated by Vincent MEMBRÉ almost 11 years ago Actions
Copy link
#13

Updated by Vincent MEMBRÉ almost 11 years ago Actions
Copy link
#14