Bug #5825
closed
rudder-jetty and rudder-inventory-ldap init scripts can fail when killall is not available
Added by Nicolas CHARLES almost 10 years ago.
Updated almost 9 years ago.
Category:
Web - Config management
Description
On a fresh Debian, killall is not installed, and I suspect that it is the same on other system (it does have killall5 thought)
After promises generation, the server attempt to run /usr/bin/killall, and fails
We shoud rather execute
kill -SIGHUP `pidof cf-serverd`
- Status changed from New to 8
- Priority changed from N/A to 1 (highest)
- Parent task deleted (
#5574)
This was introduced by #5574.
- Status changed from 8 to Pending technical review
- Assignee changed from Nicolas CHARLES to Jonathan CLARKE
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset packages:rudder-packages|commit:0e075be1b37b71dfb296acc448e3bac26dd73b4c.
Applied in changeset packages:rudder-packages|commit:7cc290fc2fbe9a1e6553fc5afcfa8695d75a5e94.
- Pull Request set to https://github.com/Normation/rudder-packages/pull/548
- Subject changed from killall is not available on all system, hence the command to reload the server after promises generation may fail to The command to reload the server after promises generation fails when killall is not available
- Status changed from Pending release to Released
This bug has been fixed in Rudder 2.11.5, which was released today (16/12/14)
- Category changed from 14 to Web - Config management
- Target version changed from 2.11.5 to 3.0.0~beta2
This ticket was erroneously marked as fixed in the 2.11 branch. However, it was only fixed in the 3.0 branch, and is part of the 3.0.0 release.
- Related to Bug #7515: rudder-agent and rudder-slapd init scripts may fail to stop services if killall is missing or misbehaving added
In fact it should have been done in 2.11, since it was already present there, it was fixed in 2.11 by #6051 and released in 2.11.7
- Subject changed from The command to reload the server after promises generation fails when killall is not available to rudder-jetty and rudder-inventory-ldap init scripts can fail when killall is not available
Vincent MEMBRÉ wrote:
In fact it should have been done in 2.11, since it was already present there, it was fixed in 2.11 by #6051 and released in 2.11.7
Actually, these bugs fix different things - #6051 only changes the command used to reload cf-serverd, but #5825 also fixes init scripts to use pidof instead of killall. Since #6051 is in 2.11, the changelog will correctly reflect this change in 2.11, and this ticket should be in the 3.0 changelog only.
I have renamed this ticket to reflect this change.
You are right, #6051 fix only a subpart of #5825 ( cf-serverd ) that should have been done in 2.11 from the beginning in another issue
I added #5825 in 3.0.0~beta2 changelog
And #7515 will backport (with improvements) this fix in 2.11 for init scripts,
Also available in: Atom
PDF