Project

General

Profile

Actions
Copy link

Bug #5872

closed

Architecture #5305: Rewrite techniques so they all use ncf report methods

Missing commas in system techniques cause invalid promises to be generated (3.0 branch)

Added by Jonathan CLARKE over 9 years ago. Updated about 9 years ago.

Status:
Released
Priority:
2
Assignee:
Nicolas CHARLES
Category:
Techniques
Target version:
3.0.0~beta1
Pull Request:
https://github.com/Normation/rudder-t...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

For example:

/var/rudder/cfengine-community/inputs.new/server-roles/1.0/postgres-check.cf:54:18: error: syntax error
        ifvarclass => "psql_conf_ok.!psql_conf_updated.!psql_conf_update_error";
                 ^

This comes from this line:

      "any" usebundle => rudder_common_report("server-roles", "result_success", "&TRACKINGKEY&", "Check PostgreSQL configuration", "None", "The SuSE specific postgresql configuration is present")
        ifvarclass => "psql_conf_ok.!psql_conf_updated.!psql_conf_update_error";

Which is missing a comma (,) after the usebundle attribute, and before the ifvarclass attribute.

There are about 40 such errors, across system techniques. This comes from #5689.

Actions
Copy link

Also available in: Atom PDF