Bug #5875
closedIt should not be possible to delete system directives
Description
I just managed to delete some system Directives:
This was possible via the Node details screen, in the reports section where all Rules and Directives have an "Edit" icon:
By clicking on this Edit icon, I could delete Directives (but not Rules). I found this in Rudder 3.0 and 2.11 via the Edit icon, but I was also able to do this on Rudder 2.10 by accessing this URL directly: https://rudder-server-name/rudder/secure/configurationManager/directiveManagement#{"directiveId":"inventory-all"}.
I suspect this is actually two bugs:- We should not be able to delete system directives (at the internal API level)
- We should not display edit links on any system directives or rules
Since this allows to delete system Directives this is quite a bad bug. However, I don't see that is has security implications, since we can only delete existing Directives, and even then only ones that keep Rudder running, and only as an admin user.
Files
Updated by François ARMAND about 10 years ago
I agree with the two bugs, the consistency one being the most important for Rudder, and the UI one being the most important for users
Updated by François ARMAND about 10 years ago
The second bug seems to be an actually different bugs, because it seems to appeared in 2.11 (in 2.10, the link are not here): #5916
Updated by François ARMAND about 10 years ago
- Pull Request set to https://github.com/Normation/rudder/pull/685
Updated by François ARMAND about 10 years ago
- Status changed from New to Pending release
- % Done changed from 0 to 100
Applied in changeset d0b04dac9f2d81a17e127bebb9a5205ea5b0107f.
Updated by Nicolas CHARLES about 10 years ago
Applied in changeset 7cb7511b27c5255048eba241c7d4a9f514c54072.
Updated by Vincent MEMBRÉ about 10 years ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 2.10.8 and 2.11.5, which were released today (16/12/14)
- Announcement 2.10 2.11
- Changelog 2.10 2.11
- Download information: https://www.rudder-project.org/site/get-rudder/downloads/