Project

General

Profile

Actions

Bug #6089

closed

enforce file content post modification hook if section is modified but global state of the file is not changed

Added by Nicolas CHARLES almost 10 years ago. Updated almost 10 years ago.

Status:
Rejected
Priority:
N/A
Category:
Techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

In case when we do several modificaiton at once on a file, we may have sub-part in repaired (like section), and a global state kept (because another change applied as well).
However, the condition on command execution is a bit laxist:

execute_command_$(index).!(content_$(index)_failed|content_deletion_failed_$(index)|content_modification_failed_$(index)).(content_$(index)_modified|content_deletion_modified_$(index)|content_modification_modified_$(index)|section_content_modification_modified_${index})

as it doesn't take into account file_edition_global_files_status_XX_kept

This happens on version 5.0 of the technique, but may also happen on 6.0


Subtasks 1 (0 open1 closed)

Bug #6094: Corect #6089 on branch 3.0, technique 7.0RejectedNicolas CHARLES2015-01-07Actions

Related issues 1 (0 open1 closed)

Is duplicate of Rudder - Bug #5312: Technique "Enforce a file content" v5.0: post-hook modification reporting is in "Uknown" status if we request a mix of insertion, deletion and/or replacementReleasedMatthieu CERDA2014-07-24Actions
Actions #1

Updated by Nicolas CHARLES almost 10 years ago

  • Assignee set to Benoît PECCATTE
Actions #2

Updated by Benoît PECCATTE almost 10 years ago

  • Status changed from New to Pending technical review
  • Assignee changed from Benoît PECCATTE to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/627
Actions #3

Updated by Nicolas CHARLES almost 10 years ago

  • Status changed from Pending technical review to Rejected

Oh, actually, I was babbling nonsence in this ticket, the issue was fixed in http://www.rudder-project.org/redmine/issues/5312, but we had a previous version of the technique, and didn't check.

I'm sorry to have wasted your time Benoît :(

Actions #4

Updated by Vincent MEMBRÉ almost 10 years ago

  • Target version changed from 2.10.9 to 2.10.10
Actions

Also available in: Atom PDF