Project

General

Profile

Actions

Bug #6205

closed

Compliance computation on home page dashboard charts is incoherent regarding pending nodes

Added by Nicolas CHARLES about 6 years ago. Updated about 6 years ago.

Status:
Released
Priority:
N/A
Category:
Web - Compliance & node report
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

I updated my rules on my system, and most of my node are in "pending" state
However, the compliance is "poor", which is disapointing (see screenshot)

Waiting a bit tells me that I do have 100% compliance, which is trye


Files

compliance.png (79.4 KB) compliance.png Nicolas CHARLES, 2015-01-30 12:03
Rudder_-_Home_-_2015-02-04_12.43.57.png (99.6 KB) Rudder_-_Home_-_2015-02-04_12.43.57.png Update compliance taking care of pending nodes François ARMAND, 2015-02-04 12:52
Actions #1

Updated by François ARMAND about 6 years ago

I see no good way of doing it:

- if we count them as "error" (like now), then we see poor compliance, even if everything is on success afterward
- if we considere "pending" as Success, then we are going to have a lot big fall in compliance when we have errors,
- if we don't count them at all, we will also have variation - but it seems to be the best idea, since in that case, at least, we don't assume a status (be it success or error), and variation will be the smallest.

So I thing we should not count them at all.

Actions #2

Updated by François ARMAND about 6 years ago

  • Pull Request set to https://github.com/Normation/rudder/pull/811

There is a proposed version for the solution 3/ in pull request: https://github.com/Normation/rudder/pull/811

Actions #3

Updated by François ARMAND about 6 years ago

There is still a question for the "Nodes by overall compliance".

I think that for that one, we should had a "Applying" case, like in " Global compliance details"

Actions #4

Updated by François ARMAND about 6 years ago

The proposed updated pull request use the following rules, that seems coherent, and at least for me doesn't make me wonder what is happening :

- the "global compliance" dismisses pending nodes ("Applying status"), so that the global compliance reflect a true, known state
- the "global compliance details" does show pending nodes
- the "node by overall compliance" does show the compliance by node, with a new case for pending nodes that are in the same "applying" status than in global compliance details

Other charts are not impacted.

See the snapshot for an overview.

Actions #5

Updated by François ARMAND about 6 years ago

  • Subject changed from Inconsistency on home page for compliance to Compliance computation on home page dashboard charts is incoherent regarding pending nodes
  • Status changed from Discussion to Pending technical review
  • Assignee changed from François ARMAND to Nicolas CHARLES
Actions #6

Updated by François ARMAND about 6 years ago

  • Assignee changed from Nicolas CHARLES to Vincent MEMBRÉ

Nicolas seems OK with the logic and the result. Vincent, could you take a look at the PR ?

Actions #7

Updated by François ARMAND about 6 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #9

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 3.0.0, which was released on 2015/02/16

Actions

Also available in: Atom PDF