Project

General

Profile

Actions

Bug #6758

closed

rudder-webapp upgrade doesn't commit updates to ncf hooks

Added by Janos Mattyasovszky almost 9 years ago. Updated about 6 years ago.

Status:
Released
Priority:
3
Category:
Packaging
Target version:
Severity:
Minor - inconvenience | misleading | easy workaround
UX impact:
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Very Small
Priority:
51
Name check:
Fix check:
Regression:

Description

10.1.2. Upgrade -> Upgrading the Technique library

--> git add techniques/

This might not be sufficient, as the ncf hooks can also be updated:

#       modified:   ncf/ncf-hooks.d/post.write_technique.commit.sh
#       modified:   ncf/ncf-hooks.d/post.write_technique.rudderify.sh

Like a 2.11.6 -> 2.11.11 update:

rudder:/var/rudder/configuration-repository # git status
# On branch master
# Changes not staged for commit:
#   (use "git add/rm <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#       deleted:    ncf/50_techniques/dfdf/dfdf.cf
#       modified:   ncf/ncf-hooks.d/post.write_technique.commit.sh
#       modified:   ncf/ncf-hooks.d/post.write_technique.rudderify.sh
#       modified:   techniques/applications/rpmPackageInstallation/6.1/rpmPackageInstallation.st
#       modified:   techniques/applications/rpmPackageInstallation/7.0/rpmPackageInstallation.st
#       modified:   techniques/applications/zypperPackageManagerRepositories/1.0/zypper-repositories-management.st
#       modified:   techniques/applications/zypperPackageManagerSettings/1.0/zypperPackageManagerSettings.st
#       modified:   techniques/applications/zypperPackageManagerSettings/2.0/zypperPackageManagerSettings.st
#       modified:   techniques/fileConfiguration/fileManagement/2.1/manageFilesAndFolders.st
#       modified:   techniques/fileConfiguration/fileManagement/3.0/manageFilesAndFolders.st
#       modified:   techniques/fileDistribution/checkGenericFileContent/5.0/checkGenericFileContent.st
#       modified:   techniques/fileDistribution/checkGenericFileContent/5.0/metadata.xml
#       modified:   techniques/fileDistribution/checkGenericFileContent/6.0/checkGenericFileContent.st
#       modified:   techniques/fileDistribution/checkGenericFileContent/6.0/metadata.xml
#       modified:   techniques/systemSettings/misc/clockConfiguration/1.0/clockConfiguration.st
#       modified:   techniques/systemSettings/misc/clockConfiguration/2.0/clockConfiguration.st
#       modified:   techniques/systemSettings/misc/genericVariableDefinition/1.0/metadata.xml
#       modified:   techniques/systemSettings/misc/genericVariableDefinition/1.1/metadata.xml
#       modified:   techniques/systemSettings/misc/genericVariableDefinition/1.2/metadata.xml
#       modified:   techniques/systemSettings/remoteAccess/sshConfiguration/3.0/config.st
#       modified:   techniques/systemSettings/remoteAccess/sshConfiguration/4.0/config.st

Would it be good to notice this, or is it sufficient to leave the git status command there and leave the admin to do the extra thinking of also including the hooks?

It will work since the files are there and will be used even without commiting it to git...


Subtasks 1 (0 open1 closed)

Bug #12116: Wrong path to ncf-hooks, debian postinst is using specfile variableReleasedVincent MEMBRÉActions
Actions

Also available in: Atom PDF