Bug #6758
closed
rudder-webapp upgrade doesn't commit updates to ncf hooks
Added by Janos Mattyasovszky over 9 years ago.
Updated over 6 years ago.
Severity:
Minor - inconvenience | misleading | easy workaround
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Very Small
Description
10.1.2. Upgrade -> Upgrading the Technique library
--> git add techniques/
This might not be sufficient, as the ncf hooks can also be updated:
# modified: ncf/ncf-hooks.d/post.write_technique.commit.sh
# modified: ncf/ncf-hooks.d/post.write_technique.rudderify.sh
Like a 2.11.6 -> 2.11.11 update:
rudder:/var/rudder/configuration-repository # git status
# On branch master
# Changes not staged for commit:
# (use "git add/rm <file>..." to update what will be committed)
# (use "git checkout -- <file>..." to discard changes in working directory)
#
# deleted: ncf/50_techniques/dfdf/dfdf.cf
# modified: ncf/ncf-hooks.d/post.write_technique.commit.sh
# modified: ncf/ncf-hooks.d/post.write_technique.rudderify.sh
# modified: techniques/applications/rpmPackageInstallation/6.1/rpmPackageInstallation.st
# modified: techniques/applications/rpmPackageInstallation/7.0/rpmPackageInstallation.st
# modified: techniques/applications/zypperPackageManagerRepositories/1.0/zypper-repositories-management.st
# modified: techniques/applications/zypperPackageManagerSettings/1.0/zypperPackageManagerSettings.st
# modified: techniques/applications/zypperPackageManagerSettings/2.0/zypperPackageManagerSettings.st
# modified: techniques/fileConfiguration/fileManagement/2.1/manageFilesAndFolders.st
# modified: techniques/fileConfiguration/fileManagement/3.0/manageFilesAndFolders.st
# modified: techniques/fileDistribution/checkGenericFileContent/5.0/checkGenericFileContent.st
# modified: techniques/fileDistribution/checkGenericFileContent/5.0/metadata.xml
# modified: techniques/fileDistribution/checkGenericFileContent/6.0/checkGenericFileContent.st
# modified: techniques/fileDistribution/checkGenericFileContent/6.0/metadata.xml
# modified: techniques/systemSettings/misc/clockConfiguration/1.0/clockConfiguration.st
# modified: techniques/systemSettings/misc/clockConfiguration/2.0/clockConfiguration.st
# modified: techniques/systemSettings/misc/genericVariableDefinition/1.0/metadata.xml
# modified: techniques/systemSettings/misc/genericVariableDefinition/1.1/metadata.xml
# modified: techniques/systemSettings/misc/genericVariableDefinition/1.2/metadata.xml
# modified: techniques/systemSettings/remoteAccess/sshConfiguration/3.0/config.st
# modified: techniques/systemSettings/remoteAccess/sshConfiguration/4.0/config.st
Would it be good to notice this, or is it sufficient to leave the git status command there and leave the admin to do the extra thinking of also including the hooks?
It will work since the files are there and will be used even without commiting it to git...
- Project changed from Rudder websites to Rudder
- Category changed from 54 to Packaging
- Priority changed from N/A to 3
- Target version set to 2.11.12
In fact those files does not need to be commited, but since they are in the git we should commit them.
The commit should be done when upgrading the rudder-webapp package (the hooks are in that package)
Thank you for reporting this Janos!
- Target version changed from 2.11.12 to 2.11.13
- Target version changed from 2.11.13 to 2.11.14
- Target version changed from 2.11.14 to 2.11.15
- Target version changed from 2.11.15 to 2.11.16
- Target version changed from 2.11.16 to 2.11.17
- Category changed from Packaging to Documentation
- Target version changed from 2.11.17 to 2.11.18
- Subject changed from Documentation issue with Technique update to rudder-webapp doesn't commit updates to ncf hooks on upgrade
- Category changed from Documentation to Packaging
We should indeed fix this so that the rudder-webapp package (that installs and updates these hooks) commits them in git if they got changed, to avoid users wondering about this. Or simply ignore them in git?
- Target version changed from 2.11.18 to 2.11.19
- Target version changed from 2.11.19 to 2.11.20
- Target version changed from 2.11.20 to 2.11.21
- Target version changed from 2.11.21 to 2.11.22
- Target version changed from 2.11.22 to 2.11.23
- Target version changed from 2.11.23 to 2.11.24
- Target version changed from 2.11.24 to 308
- Target version changed from 308 to 3.1.14
- Target version changed from 3.1.14 to 3.1.15
- Target version changed from 3.1.15 to 3.1.16
- Target version changed from 3.1.16 to 3.1.17
- Target version changed from 3.1.17 to 3.1.18
- Target version changed from 3.1.18 to 3.1.19
- Subject changed from rudder-webapp doesn't commit updates to ncf hooks on upgrade to rudder-webapp upgrade doesn't commit updates to ncf hooks
- Severity set to Minor - inconvenience | misleading | easy workaround
- User visibility set to Operational - other Techniques | Technique editor | Rudder settings
- Priority set to 14
- Target version changed from 3.1.19 to 3.1.20
- Target version changed from 3.1.20 to 3.1.21
- Target version changed from 3.1.21 to 3.1.22
- Priority changed from 14 to 27
- Effort required set to Very Small
- Priority changed from 27 to 41
- Target version changed from 3.1.22 to 3.1.23
- Target version changed from 3.1.23 to 3.1.24
- Target version changed from 3.1.24 to 3.1.25
- Priority changed from 41 to 51
- Target version changed from 3.1.25 to 387
- Target version changed from 387 to 4.1.10
- Status changed from New to In progress
- Assignee set to Benoît PECCATTE
- Status changed from In progress to Pending technical review
- Assignee changed from Benoît PECCATTE to Alexis Mousset
- Pull Request set to https://github.com/Normation/rudder-packages/pull/1501
- Assignee changed from Alexis Mousset to Benoît PECCATTE
- Status changed from Pending technical review to Pending release
- Status changed from Pending release to Released
This bug has been fixed in Rudder 4.1.10 and 4.2.4 which were released today.
Also available in: Atom
PDF