Architecture #7040: Duplicate init scripts in rudder-agent: rudder-agent include rudder.init - Rudder - Issue Tracker

Actions

Copy link

Architecture #7040

closed

Duplicate init scripts in rudder-agent: rudder-agent include rudder.init

Added by Francois BAYART over 8 years ago. Updated over 5 years ago.

Status:

Rejected

Priority:

N/A

Assignee:

Benoît PECCATTE

Category:

Packaging

Target version:

Ideas (not version specific)

Pull Request:

Effort required:

Name check:

Fix check:

Regression:

Description

I'm making rudder agent packages for Raspbian with 3.1.0 release. On RaspberryPi I need to have a high start level so rudder-agent is started as S22 and not S17 but with v3.1.0 come with a new file named "rudder" and it's start level is S17.

https://github.com/Normation/rudder-packages/blob/branches/rudder/3.1/rudder-agent/SOURCES/rudder.init

I don't understand if it's a source error (this file indicate "rudder server" in comments but it's present un rudder-agent) or if I need to include it in my package build ?

Is it here to replace /etc/init.d/rudder-agent ? If yes why did you kept /etc/init.d/rudder-agent ?

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Nicolas CHARLES over 8 years ago

this file was created in 3.1, via the ticket http://www.rudder-project.org/redmine/issues/6513
The gola of this script is to handle every component of rudder (server and agent), and have a unique init script for all

Actions

Copy link

Updated by Francois BAYART over 8 years ago

Nicolas CHARLES wrote:

this file was created in 3.1, via the ticket http://www.rudder-project.org/redmine/issues/6513
The gola of this script is to handle every component of rudder (server and agent), and have a unique init script for all

OK, so /etc/init.d/rudder is the official init script. Why did you keep /etc/init.d/rudder-agent ?

My 2cts: I suppose it's a smart idea but you are not really KISS with the generic rudder init script, and it's not very cool for monitoring.

Actions

Copy link

Updated by Benoît PECCATTE over 8 years ago

Category set to Packaging
Assignee set to Francois BAYART
Target version set to 3.1.1

rudder.init was made to automatically run all other rudder service in proper order and with proper version/configuration ...

This is the service that should be run automatically at boot whereas the other should not.
Since rudder-agent.init is called by rudder.init it should be kept.

In practice, rudder.init makes a difference only if you have a server installed with the agent.

Actions

Copy link

Updated by Francois BAYART over 8 years ago

Benoît PECCATTE wrote:

rudder.init was made to automatically run all other rudder service in proper order and with proper version/configuration ...
This is the service that should be run automatically at boot whereas the other should not.
Since rudder-agent.init is called by rudder.init it should be kept.

without the respect of the init startlevel, as explained in my issue description, rudder = S17 but rudder-agent = S22; now rudder-agent is started before S22 so I suppose it's started with rudder in S17

In practice, rudder.init makes a difference only if you have a server installed with the agent.

no, I have an impact on an installation with agent only.

Actions

Copy link

Updated by Benoît PECCATTE over 8 years ago

without the respect of the init startlevel, as explained in my issue description, rudder = S17 but rudder-agent = S22; now rudder-agent is started before S22 so I suppose it's started with rudder in S17

Yes

In practice, rudder.init makes a difference only if you have a server installed with the agent.

no, I have an impact on an installation with agent only.

I meant that it doesn't provide any added value it you don't have a server installed on the same host.

Actions

Copy link

Updated by Vincent MEMBRÉ over 8 years ago

Target version changed from 3.1.1 to 3.1.2

Actions

Copy link

Updated by Jonathan CLARKE over 8 years ago

Tracker changed from Question to Bug
Subject changed from rudder-agent include rudder.init to Duplicate init scripts in rudder-agent: rudder-agent include rudder.init
Assignee changed from Francois BAYART to Benoît PECCATTE
Target version changed from 3.1.2 to 3.2.0~beta1

I tend to agree with François here - on a node (with just rudder-agent) this is just plain confusing, and certainly a long way from POLA. We make a lot of effort to provide just one package, one service, etc, to keep things simple. Therefore having 2 init scripts and not knowing which one to choose does not make sense (on a node).

On the server, I can see the value of this. But I think it would be better named rudder-server. And I definitely think we should only install that on the server, so that a node only has one init script (rudder-agent).

I don't think we should remove an init script in a maintenance release, so targeting this for 3.2.

Actions

Copy link