Bug #7211
closed
System technique's curl should follow redirects
Description
When an agent is executed it'll check it's servers' UUID.
This is done using http, regardless of the setting here:
common/1.0/site.st: "inventory_upload_protocol" string => "https";
We've long put a redirect in place but found this is not being followed by curl.
It fetches the redirect message, and decides it doesn't parse as a legit UUID.
Adding -L to the general rudder curl options seems (to me) be a nice way of cleaning this.
If a redirect is encountered, curl then follows it (i.e. to https on same system), and the content check stays still in place.
I don't know if it can be done for minicurl and what you have on Windows.
Updated by Janos Mattyasovszky over 8 years ago
This should also be implemented for the inventory-upload's curl:
./fusionAgent.cf: "download_command" string => "${g.rudder_curl} -L -k -s -f --proxy '' -o \"${g.rudder_var_tmp}/uuid.txt\" http://${server_info.cfserved}/uuid";
./fusionAgent.cf: "download_command_prefix" string => "${g.rudder_curl} -L -f -s --proxy '' --user ${g.davuser}:${g.davpw} -T";
Note the -L in the curl.
Updated by Benoît PECCATTE over 8 years ago
- Assignee set to Benoît PECCATTE
- Target version set to 2.11.15
- minicurl already follows redirects
- windows uses curl too
Updated by Benoît PECCATTE over 8 years ago
- Status changed from New to In progress
Updated by Benoît PECCATTE over 8 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Benoît PECCATTE to Matthieu CERDA
- Pull Request set to https://github.com/Normation/rudder-techniques/pull/752
Updated by Benoît PECCATTE over 8 years ago
- Assignee changed from Matthieu CERDA to Benoît PECCATTE
Janos: the protocol used for the first query cannot be configured yet, so it is http for now.
Subsequent requests should however be made in the configured protocol.
Updated by Benoît PECCATTE over 8 years ago
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset rudder-techniques|0038fcb1f77598944c119e7d37253f8c00916d7a.
Updated by Matthieu CERDA over 8 years ago
Applied in changeset rudder-techniques|3f5271e356847c7b663d1dcaf6e6812c72b31ffc.
Updated by Vincent MEMBRÉ over 8 years ago
- Category changed from Techniques to System techniques
Updated by Vincent MEMBRÉ over 8 years ago
- Status changed from Pending release to Released