Project

General

Profile

Actions
Copy link

Bug #7286

closed

Link from node/directive list to node detail is broken on Firefox

Bug #7286: Link from node/directive list to node detail is broken on Firefox

Added by Nicolas CHARLES over 10 years ago. Updated over 10 years ago.

Status:
Released
Priority:
N/A
Assignee:
Vincent MEMBRÉ
Category:
Web - Nodes & inventories
Target version:
2.10.19
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

On latest version of Chromium/Firefox, when we click on the loop on the node list, we arrive to the searchNode page with the correct URL, however, the node detail is not loaded
Breaks on Firefox 44, Chromium 46

It works perfectly on Chromium 45, Forefox 31 (and some version in between 44 and 31, needs further testing)

Subtasks 1 (0 open — 1 closed)

Bug #7287: Link from node/directive list to node detail is broken on Firefox (branch 3.0)ReleasedVincent MEMBRÉActions

Related issues 1 (0 open — 1 closed)

Related to Rudder - Bug #7380: Javascript error on Rudder 3.2 with ChromiumReleasedFrançois ARMANDActions

Updated by Nicolas CHARLES over 10 years ago Actions
Copy link
 #1

The parsing of the nodeId is made by

JSON.parse(window.location.hash.substring(1));
SyntaxError: JSON.parse: expected property name or '}' at line 1 column 2 of the JSON data

JSON.parse(window.location.hash.substring(1));

which fails

window.location.hash.substring(1);
"{%22nodeId%22:%220c846655-cb06-486f-ace4-eaeb11372097%22}"

Updated by Nicolas CHARLES over 10 years ago Actions
Copy link
 #3 

JSON.parse(decodeURI(window.location.hash.split("#")[1]));

seems to fix the issue on firefox

Updated by Nicolas CHARLES over 10 years ago Actions
Copy link
 #4

  • Subject changed from Link from node list to node detail is broken on Firefox to Link from node/directive list to node detail is broken on Firefox

this also happen for the directives link!

Updated by Nicolas CHARLES over 10 years ago Actions
Copy link
 #5

  • Subject changed from Link from node/directive list to node detail is broken on Firefox to Link from node/directive list to node detail is broken on Firefox (branch 2.10)

Updated by Nicolas CHARLES over 10 years ago Actions
Copy link
 #6

  • Status changed from New to Pending technical review
  • Pull Request set to https://github.com/Normation/rudder/pull/930/files

Updated by Nicolas CHARLES over 10 years ago Actions
Copy link
 #7

  • Related to Bug #7287: Link from node/directive list to node detail is broken on Firefox (branch 3.0) added

Updated by Nicolas CHARLES over 10 years ago Actions
Copy link
 #8

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Updated by Nicolas CHARLES over 10 years ago Actions
Copy link
 #10

  • Description updated (diff)

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #11

  • Subject changed from Link from node/directive list to node detail is broken on Firefox (branch 2.10) to Link from node/directive list to node detail is broken on Firefox

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #12

  • Related to deleted (Bug #7287: Link from node/directive list to node detail is broken on Firefox (branch 3.0))

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #13

This bug has been fixed in Rudder 2.10.19, 2.11.16, 3.0.11 and 3.1.4 which were released today.

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #14

  • Status changed from Pending release to Released

Updated by Nicolas CHARLES over 10 years ago Actions
Copy link
 #15

  • Related to Bug #7380: Javascript error on Rudder 3.2 with Chromium added
Actions
Copy link

Also available in: PDF Atom