Bug #7560
closed
Bug #7557: Promises are not regenerated during upgrade
Reload technique API call must be synchrone
Description
There is not advantage to have technique reload asynchrone safe the gain in time (but reloading techniques takes hundred of millesonds, not of seconds) and we are getting bugs on bugs on it. And it is very surprising for an user to have a "OK" with an error in logs.
So just make it synchrone, and be done with it.
Updated by François ARMAND over 8 years ago
- Related to Bug #5685: Raise errors if there's issues with a technique created with ncf-builder added
Updated by François ARMAND over 8 years ago
OK, so actually, the call is ALREADY synchrone.
The problem in the parent ticket is that the callbacks error are not bulling-up to the command results, what is strange.
It makes sense that an error in one callback does not stop the call to other callback. But any error should be reported and change the global result of the command.
Updated by François ARMAND over 8 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from François ARMAND to Vincent MEMBRÉ
- Pull Request set to https://github.com/Normation/rudder/pull/987
Updated by François ARMAND over 8 years ago
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset rudder|4ce8c56b8b02791e5ed1a2f4f260d04ddc43dc0f.
Updated by Vincent MEMBRÉ over 8 years ago
Applied in changeset rudder|a7b813d78bc6a6feeb42031cbee7823b3af8aee8.
Updated by Vincent MEMBRÉ over 8 years ago
- Status changed from Pending release to Released