Project

General

Profile

Actions

Bug #7766

closed

Too long directive name breaks directive serialization

Added by Vincent MEMBRÉ over 5 years ago. Updated over 5 years ago.

Status:
Released
Priority:
1
Category:
Web - Config management
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

Having a too long directive name breaks several parts of UI (more than 100 chars long).

This case the xml archive in git repository to be invalid:

What we want:

   <displayName>the name of the directive</displayName>

What we got:

   <displayName>
     the name of the directive
   </displayName>

WHen restoring the archive containing this the Directive name is now considered to be on 3 lines instead of one

One of the case, webapp makes a "Server cannot be contacted at this time" when adding/removing that directive from a Rule. (javascript became invalid, a string contains the name of the directive ...)

Improving max length of prettifier should prevent this issue ( Set to Int.max )

triming name when unserialising, will allow to work with broken archive

Actions #1

Updated by Vincent MEMBRÉ over 5 years ago

  • Status changed from New to In progress
  • Assignee set to Vincent MEMBRÉ
Actions #2

Updated by Vincent MEMBRÉ over 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/1029
Actions #3

Updated by Vincent MEMBRÉ over 5 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #4

Updated by Vincent MEMBRÉ over 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.18, 3.0.13, 3.1.6 and 3.2.0 which were released today.

Actions

Also available in: Atom PDF