Project

General

Profile

Actions

Bug #7766

closed

Too long directive name breaks directive serialization

Added by Vincent MEMBRÉ over 8 years ago. Updated about 8 years ago.

Status:
Released
Priority:
1
Category:
Web - Config management
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

Having a too long directive name breaks several parts of UI (more than 100 chars long).

This case the xml archive in git repository to be invalid:

What we want:

   <displayName>the name of the directive</displayName>

What we got:

   <displayName>
     the name of the directive
   </displayName>

WHen restoring the archive containing this the Directive name is now considered to be on 3 lines instead of one

One of the case, webapp makes a "Server cannot be contacted at this time" when adding/removing that directive from a Rule. (javascript became invalid, a string contains the name of the directive ...)

Improving max length of prettifier should prevent this issue ( Set to Int.max )

triming name when unserialising, will allow to work with broken archive

Actions

Also available in: Atom PDF