Project

General

Profile

Actions

Bug #7984

closed

Rudder commits empty changes into git

Added by Janos Mattyasovszky over 8 years ago. Updated over 2 years ago.

Status:
Rejected
Priority:
N/A
Assignee:
-
Category:
Web - Config management
Target version:
Severity:
Minor - inconvenience | misleading | easy workaround
UX impact:
User visibility:
Infrequent - complex configurations | third party integrations
Effort required:
Priority:
22
Name check:
Fix check:
Regression:

Description

Rudder commits on every group update, even if there was actually no real change.
This pollutes the git history by adding empty commits.

Example:

rootserver:/var/rudder/configuration-repository # git log -v -p | head -n18
commit 0f2b885ab3c1fce71634aca6c9fd7010796d1d81
Author: rudder <email not set>
Date:   Fri Feb 26 12:03:24 2016 +0100

    Archive of node group with ID 'a2ab2334-f998-4ba0-bae9-ccbd11cf461d'

    Reason provided by user:
    Update group due to batch update of dynamic groups

commit aba6122a0cb4f9357d33068211ff1b6c0b416bdf
Author: rudder <email not set>
Date:   Fri Feb 26 12:03:10 2016 +0100

    Archive of node group with ID '97882090-29e2-43ab-b554-f40fb208bc8e'

    Reason provided by user:
    Update group due to batch update of dynamic groups

Actions #1

Updated by François ARMAND about 8 years ago

  • Target version set to 2.11.20

Well, I'm not sure how git do that. You're totally right (and if I remember correctly the developper will, he thought that git wasn't doing empty commit).

Actions #2

Updated by François ARMAND about 8 years ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND
Actions #3

Updated by François ARMAND about 8 years ago

So, the good new is that we do take care of that case in the code: if(autoExportOnModify && optDiff.isDefined && !nodeGroup.isSystem) { //only persists if modification are present

The bad news is that I will need some more time to reproduce (I mean, reproduce it in a controled envirenment) and understand that one.

Actions #4

Updated by François ARMAND about 8 years ago

Janos, did you have message like that:

Auto-archive git failure: not found in git added files: 'path/to/the/group/xml/file'. You can safelly ignore that warning if the file was already existing in Git and was not modified by that archive.

in /var/log/rudder/webapp/* for date corresponding for when the empty commit where created?

Actions #5

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 2.11.20 to 2.11.21
Actions #6

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 2.11.21 to 2.11.22
Actions #7

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 2.11.22 to 2.11.23
Actions #8

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 2.11.23 to 2.11.24
Actions #9

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 2.11.24 to 308
Actions #10

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 308 to 3.1.14
Actions #11

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.14 to 3.1.15
Actions #12

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.15 to 3.1.16
Actions #13

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.16 to 3.1.17
Actions #14

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.17 to 3.1.18
Actions #15

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.18 to 3.1.19
Actions #16

Updated by Jonathan CLARKE about 7 years ago

  • Severity set to Minor - inconvenience | misleading | easy workaround
  • User visibility set to Infrequent - complex configurations | third party integrations
Actions #17

Updated by Benoît PECCATTE about 7 years ago

  • Priority set to 5
Actions #18

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 3.1.19 to 3.1.20
Actions #19

Updated by Jonathan CLARKE about 7 years ago

  • Status changed from In progress to New
Actions #20

Updated by Jonathan CLARKE about 7 years ago

  • Assignee deleted (François ARMAND)
Actions #21

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 3.1.20 to 3.1.21
Actions #22

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 3.1.21 to 3.1.22
Actions #23

Updated by Benoît PECCATTE almost 7 years ago

  • Priority changed from 5 to 18
Actions #24

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 3.1.22 to 3.1.23
Actions #25

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 3.1.23 to 3.1.24
Actions #26

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.24 to 3.1.25
Actions #27

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.25 to 387
Actions #28

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 387 to 4.1.10
Actions #29

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.1.10 to 4.1.11
Actions #30

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.1.11 to 4.1.12
Actions #31

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.1.12 to 4.1.13
Actions #32

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.1.13 to 4.1.14
Actions #33

Updated by Benoît PECCATTE almost 6 years ago

  • Target version changed from 4.1.14 to 4.1.15
Actions #34

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.15 to 4.1.16
Actions #35

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.16 to 4.1.17
Actions #36

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.17 to 4.1.18
Actions #37

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.18 to 4.1.19
Actions #38

Updated by Alexis Mousset over 5 years ago

  • Target version changed from 4.1.19 to 4.1.20
Actions #39

Updated by François ARMAND over 5 years ago

  • Target version changed from 4.1.20 to 4.1.21
Actions #40

Updated by Vincent MEMBRÉ about 5 years ago

  • Target version changed from 4.1.21 to 4.1.22
Actions #41

Updated by Vincent MEMBRÉ about 5 years ago

  • Target version changed from 4.1.22 to 4.1.23
Actions #42

Updated by Vincent MEMBRÉ about 5 years ago

  • Target version changed from 4.1.23 to 4.1.24
Actions #43

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 4.1.24 to 588
  • Priority changed from 18 to 19
Actions #44

Updated by François ARMAND almost 5 years ago

  • Target version changed from 588 to 5.0.13
Actions #45

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 5.0.13 to 5.0.14
Actions #46

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 5.0.14 to 5.0.15
Actions #47

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 5.0.15 to 5.0.16
Actions #48

Updated by Alexis Mousset over 4 years ago

  • Target version changed from 5.0.16 to 5.0.17
  • Priority changed from 19 to 20
Actions #49

Updated by Vincent MEMBRÉ about 4 years ago

  • Target version changed from 5.0.17 to 5.0.18
Actions #50

Updated by Vincent MEMBRÉ almost 4 years ago

  • Target version changed from 5.0.18 to 5.0.19
  • Priority changed from 20 to 21
Actions #51

Updated by Vincent MEMBRÉ almost 4 years ago

  • Target version changed from 5.0.19 to 5.0.20
Actions #52

Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 5.0.20 to 797
Actions #53

Updated by Benoît PECCATTE almost 3 years ago

  • Target version changed from 797 to 6.1.14
  • Priority changed from 21 to 22
Actions #54

Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 6.1.14 to 6.1.15
Actions #55

Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 6.1.15 to 6.1.16
Actions #56

Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 6.1.16 to 6.1.17
Actions #57

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.1.17 to 6.1.18
Actions #58

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.1.18 to 6.1.19
Actions #59

Updated by François ARMAND over 2 years ago

  • Status changed from New to Rejected

We added some more checks but weren't able to reproduce it. I'm closing that ticket, but if you still have that, please reopen it.

Actions

Also available in: Atom PDF