Bug #7984: Rudder commits empty changes into git - Rudder - Issue Tracker

Actions

Copy link

Bug #7984

closed

Rudder commits empty changes into git

Added by Janos Mattyasovszky almost 9 years ago. Updated almost 3 years ago.

Status:

Rejected

Priority:

N/A

Assignee:

Category:

Web - Config management

Target version:

6.1.19

Pull Request:

Severity:

Minor - inconvenience | misleading | easy workaround

UX impact:

User visibility:

Infrequent - complex configurations | third party integrations

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

Rudder commits on every group update, even if there was actually no real change.
This pollutes the git history by adding empty commits.

Example:

rootserver:/var/rudder/configuration-repository # git log -v -p | head -n18
commit 0f2b885ab3c1fce71634aca6c9fd7010796d1d81
Author: rudder <email not set>
Date:   Fri Feb 26 12:03:24 2016 +0100

    Archive of node group with ID 'a2ab2334-f998-4ba0-bae9-ccbd11cf461d'

    Reason provided by user:
    Update group due to batch update of dynamic groups

commit aba6122a0cb4f9357d33068211ff1b6c0b416bdf
Author: rudder <email not set>
Date:   Fri Feb 26 12:03:10 2016 +0100

    Archive of node group with ID '97882090-29e2-43ab-b554-f40fb208bc8e'

    Reason provided by user:
    Update group due to batch update of dynamic groups

Actions

Copy link

Updated by François ARMAND almost 9 years ago

Target version set to 2.11.20

Well, I'm not sure how git do that. You're totally right (and if I remember correctly the developper will, he thought that git wasn't doing empty commit).

Actions

Copy link

Updated by François ARMAND almost 9 years ago

Status changed from New to In progress
Assignee set to François ARMAND

Actions

Copy link

Updated by François ARMAND almost 9 years ago

So, the good new is that we do take care of that case in the code: if(autoExportOnModify && optDiff.isDefined && !nodeGroup.isSystem) { //only persists if modification are present

The bad news is that I will need some more time to reproduce (I mean, reproduce it in a controled envirenment) and understand that one.

Actions

Copy link

Updated by François ARMAND almost 9 years ago

Janos, did you have message like that:

Auto-archive git failure: not found in git added files: 'path/to/the/group/xml/file'. You can safelly ignore that warning if the file was already existing in Git and was not modified by that archive.

in /var/log/rudder/webapp/* for date corresponding for when the empty commit where created?

Actions

Copy link

Updated by Vincent MEMBRÉ over 8 years ago

Target version changed from 2.11.20 to 2.11.21

Actions

Copy link

Updated by Vincent MEMBRÉ over 8 years ago

Target version changed from 2.11.21 to 2.11.22

Actions

Copy link

Updated by Vincent MEMBRÉ over 8 years ago

Target version changed from 2.11.22 to 2.11.23

Actions

Copy link

Updated by Vincent MEMBRÉ over 8 years ago

Target version changed from 2.11.23 to 2.11.24

Actions

Copy link

Updated by Vincent MEMBRÉ over 8 years ago

Target version changed from 2.11.24 to 308

Actions

Copy link

#10

Updated by Vincent MEMBRÉ over 8 years ago

Target version changed from 308 to 3.1.14

Actions

Copy link

#11

Updated by Vincent MEMBRÉ about 8 years ago

Target version changed from 3.1.14 to 3.1.15

Actions

Copy link

#12

Updated by Vincent MEMBRÉ about 8 years ago

Target version changed from 3.1.15 to 3.1.16

Actions

Copy link

#13

Updated by Vincent MEMBRÉ about 8 years ago

Target version changed from 3.1.16 to 3.1.17

Actions

Copy link

#14

Updated by Vincent MEMBRÉ about 8 years ago

Target version changed from 3.1.17 to 3.1.18

Actions

Copy link

#15

Updated by Vincent MEMBRÉ almost 8 years ago

Target version changed from 3.1.18 to 3.1.19

Actions

Copy link

#16

Updated by Jonathan CLARKE almost 8 years ago

Severity set to Minor - inconvenience | misleading | easy workaround
User visibility set to Infrequent - complex configurations | third party integrations

Actions

Copy link

#17