Project

General

Profile

Actions

Architecture #8005

closed

API directives - one extra nesting level?

Added by Florian Heigl almost 9 years ago. Updated 8 months ago.

Status:
Rejected
Priority:
N/A
Assignee:
-
Category:
API
Effort required:
Name check:
Fix check:
Regression:
No

Description

If you query variable directives via the API it seems they're nested one level too deep.

See the screenshot, and i'm not 100% sure, but this could be something for $future to make the API a bit more friendly to use.


Files

rudder_directives_api.png (79.8 KB) rudder_directives_api.png Florian Heigl, 2016-02-29 23:02
Actions #1

Updated by Benoît PECCATTE over 8 years ago

  • Target version set to 4.0.0~rc2
Actions #2

Updated by François ARMAND about 8 years ago

Hum.

For an explanation before even trying to know if it is ok: it is due to the structure of directive parameters: there is a root section (unique, root tag in XML fashion), and under it there is the section for each real section.
Moreover, we are encapsulating each set of parameter in a section.
So what you see is the actual tree of parameters for the directive - in a "just dump the damn thing" mode.

So, is it ok ?
I don't think it is at all OK. And clearly, there is a lot of redondancy, not even in "section", but also in "var" - we could have an array of pairs or something.

The problem right now is that breaking changes in API are a bad thing. So we need to have to really take some time to make the change sufficiently compeling people are not upsetted by the need to change their scripts.

Actions #3

Updated by François ARMAND about 8 years ago

  • Target version changed from 4.0.0~rc2 to 4.1.0~beta1
Actions #4

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 4.1.0~beta1 to 4.1.0~beta2
Actions #5

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 4.1.0~beta2 to 4.1.0~beta3
Actions #6

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 4.1.0~beta3 to 4.1.0~rc1
Actions #7

Updated by François ARMAND almost 8 years ago

  • Target version changed from 4.1.0~rc1 to 4.2.0~beta1
Actions #8

Updated by Alexis Mousset over 7 years ago

  • Target version changed from 4.2.0~beta1 to 4.2.0~beta2
Actions #9

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.2.0~beta2 to 4.2.0~beta3
Actions #10

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.2.0~beta3 to 4.2.0~rc1
Actions #11

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.2.0~rc1 to 4.2.0~rc2
Actions #12

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.2.0~rc2 to 4.2.0
Actions #13

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 4.2.0 to 4.2.1
Actions #14

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 4.2.1 to 4.2.2
Actions #15

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 4.2.2 to 4.2.3
Actions #16

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 4.2.3 to 4.2.4
Actions #17

Updated by Benoît PECCATTE almost 7 years ago

  • Target version changed from 4.2.4 to Ideas (not version specific)
Actions #18

Updated by François ARMAND 8 months ago

  • Status changed from New to Rejected
  • Regression set to No

Closing as intended like that.

Actions

Also available in: Atom PDF